Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Six, Lancelot via Gdb-patches" <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PATCH 1/2] gdb: Fix regression in varobj recreation
Date: Wed, 3 Aug 2022 09:06:29 +0000	[thread overview]
Message-ID: <DM4PR12MB5745D5C058351D84452B6E03839C9@DM4PR12MB5745.namprd12.prod.outlook.com> (raw)
In-Reply-To: <dd42041a-8dab-a257-77cc-e504be231ec6@suse.de>

[Public]

> > "bc20e562ec0 gdb/varobj: Fix use after free in varobj" introduced a
> 
> I'd do:
> ...
> Commit bc20e562ec0 "gdb/varobj: Fix use after free in varobj" introduced a
> ...
> in other words, start the line with a word rather than a git hash, and
> do the quoting around "$subject".
> [...]
> 
> stall -> stale
> 
> >
> 
> LGTM.
> 
> Thanks,
> - Tom
> 

Hi,

I have pushed this patch with the fixes as you suggested.

Thanks,
Lancelot.

  reply	other threads:[~2022-08-03  9:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 12:47 [PATCH 0/2] Fix regressions " Lancelot SIX via Gdb-patches
2022-08-02 12:47 ` [PATCH 1/2] gdb: Fix regression " Lancelot SIX via Gdb-patches
2022-08-02 13:26   ` Tom de Vries via Gdb-patches
2022-08-03  9:06     ` Six, Lancelot via Gdb-patches [this message]
2022-08-02 12:47 ` [PATCH 2/2] gdb/testsuite: Accept PIE/noPIE programs in gdb.mi/mi-var-invalidate-shlib.exp Lancelot SIX via Gdb-patches
2022-08-02 15:45   ` Tom de Vries via Gdb-patches
2022-08-03  9:35     ` Six, Lancelot via Gdb-patches
2022-08-03 11:51       ` Tom de Vries via Gdb-patches
2022-08-03 13:23         ` Six, Lancelot via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5745D5C058351D84452B6E03839C9@DM4PR12MB5745.namprd12.prod.outlook.com \
    --to=gdb-patches@sourceware.org \
    --cc=Lancelot.Six@amd.com \
    --cc=lsix@lancelotsix.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox