From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MOGhMLU66mKasB8AWB0awg (envelope-from ) for ; Wed, 03 Aug 2022 05:07:01 -0400 Received: by simark.ca (Postfix, from userid 112) id B143C1EA05; Wed, 3 Aug 2022 05:07:01 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ZLd0DWZt; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5D5011E9ED for ; Wed, 3 Aug 2022 05:06:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7ECCB385AC29 for ; Wed, 3 Aug 2022 09:06:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7ECCB385AC29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659517618; bh=VifPdMDihe5uzKWaPy/LEwa9l/vHl1j2g/FcoctGQwg=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZLd0DWZt6qz167YH2O9a8xsszJgeWy2KCWWwW+xxQcNfSQMnZBw6Ubm2L7rYB1YmY 9sf9cphomg0AUx2YNzDwUWbrI4noncX1gZTnbi2ALl74Umg9JYj9dEOOmYJQZ/06iV w/pZAXCpCWjk9Grh+4SAGfz0xp2XM81ATLJ9hLiw= Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by sourceware.org (Postfix) with ESMTPS id 0CFC538515FA for ; Wed, 3 Aug 2022 09:06:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0CFC538515FA ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=loF/QGnmj04rmt5tVE67/+LXSk92JadZhcdb3Ed4l84WzQ+w+xXaujDgD92I0H/IGmOCHuNs7LK57yoYoJyuO7coH/34t48XqRxlQtlmFppQjsv5ktSVSAryBrBHnoep5L9HgxoBE6PVqyTWEvhqLgrHNqpOMKsNHLJWB7Pjg42GpTBUBHzuFSf8CjfBQ3DGY/E8DArKuLMKJnZ5L0bYAt9KY/mndg784HM6aR+SUmFjInmu/TlgbBF/xk+cPgottU8x5cqi3cGOIS/r5gOIVBgbfCR3OpclgpYpU1l13yiHj4QcnhuG+d9bT5VyEcVulD/hgZ9gDhnh2ZJWdo83ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VifPdMDihe5uzKWaPy/LEwa9l/vHl1j2g/FcoctGQwg=; b=Vsl8eWYwQM8LihUslqLtxmaomcTG1u7AgWM9HTNiUW5m2gOy4llPNl4eDss1xMno6dti27AaxTWpje7qpMSiWACQdegV/XMd8HSbAQNCGyJdWrH5upIOAT7OODBHM/n1gV3fOHpvm1HjiaWF7vYWlC2NsalCH3l1IhCBFyDfEwTENFOuXdhbquVdZltFW2e4tYZMu1nb/hxZIrcH3GTjyu3w79U3e2qh8HCez7LLzY7ofuu1I0iMFih6F58Q6RLFFM8VJQkPlDINVKNPheK2Jbv8hLfoOG7Klzec7tX161f2BJxkFfEvjlS5FRqo5XV9WgY1/6tzZ7CIWdDB9IA/hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by DM6PR12MB4732.namprd12.prod.outlook.com (2603:10b6:5:32::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 3 Aug 2022 09:06:29 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::9155:e480:2c04:aed1]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::9155:e480:2c04:aed1%3]) with mapi id 15.20.5482.016; Wed, 3 Aug 2022 09:06:29 +0000 To: Tom de Vries , "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/2] gdb: Fix regression in varobj recreation Thread-Topic: [PATCH 1/2] gdb: Fix regression in varobj recreation Thread-Index: AQHYpm4SePnh7YzkLEuOdwsaM1ZLV62bmjSAgAFI8DA= Date: Wed, 3 Aug 2022 09:06:29 +0000 Message-ID: References: <20220802124724.284096-1-lancelot.six@amd.com> <20220802124724.284096-2-lancelot.six@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-08-03T09:04:28Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=9860381f-d7a4-426c-963b-19ef68188449; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-08-03T09:06:26Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 7102b087-f5f0-4a85-8d83-fd08ca6de386 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f2eb623-b79d-46f4-c397-08da752f740c x-ms-traffictypediagnostic: DM6PR12MB4732:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zcMWDkc754MF9jGi0aui1tQ1y6frGueJunxp+LWHERK8fqrrqw3TYzHxwXfW3g6Z0tdxya32fL1AKPsQmVGq5XvfNsu8Wx8ywO/v+YaNuxrsrlJ9Tv666Fg4RJhJGLt+tUWVZNRszLRjQmDkdveZYx5HKaAkoi9oBw+SR9DpKSSWxuqUFZihBHauSW3B/P3n634AYm4P2mbL8M7Du5q7wpHl1E6JgHWpqXIhmmlLKrszhV18Oj4/JLJyUUw+rEkzqEGlHdP1Dg8nUntuVy3po2JOKq4xU+Y84drv3AJUZ/8Z5wMPvfzmhAyek5OHmTQkJQGw3iwcND4CE4UJmU6W2wK3lAIFYiBY+A7qU53+CvEMiL/wf94mAgp/ZiETj8bJEc3XDC948iHh1+HlYfeMpCOQtrPULaNCoBCDGDp5rER+GTTU/Z7sVFLSzJfiLEtchBFFZOwH8goUVk3E0bpJvkyPqjTrxg53tWHOLeoebgaycyO/mhswPGKD4pLndlxXkrNxpDnkiKU8jfYPlU1Rb+JoawpCocISNMg4XfMjGGefRf6J1nZg6DjYq4buvDxFED/I+vAcx/FrsZi13m68/qWiEc2CM7Akd/aAQ0FgZb4uzHQ33xeTjL2XgRuZc64cT8S+4Ip3qr3oKqCEkxmD8ouQsB/3O2hyEqFltIIUHv+jceyaMxhMVlLdJHvS9INm1PSKZK9Fo5RYmm3v+MsglRSogbka548VU3YHUlscGPG4rFVm7ok4hBsvjHHT4f917Igk/5cKGjoh/x1acFICAsYu88edbDLPAv8b1QZLxRE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5745.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(366004)(396003)(376002)(136003)(39860400002)(38100700002)(38070700005)(122000001)(2906002)(71200400001)(8676002)(4326008)(66446008)(64756008)(66946007)(76116006)(110136005)(66476007)(66556008)(316002)(26005)(9686003)(5660300002)(186003)(4744005)(41300700001)(478600001)(6506007)(7696005)(52536014)(8936002)(55016003)(86362001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mIsSe9HWlnUjmyDm5mB7GH10kwHnGyARGwG6Y3mT7jjHHAB40ZFvUz8hTyEH?= =?us-ascii?Q?5Q9ZJJtUaKdTOYXV4X0H6nDBrXd0eVGDZucOcH9BhLQUCvzaMUfQ/qx39EHQ?= =?us-ascii?Q?0nKHifwd4x4TuiwzXAQuMAsZ6vp48d1yqCGOf/vcQUF6xSSpBKqMoUptqaRY?= =?us-ascii?Q?2gDgddxJ3ErX7yIaRHBB24272aoAds8ziXDynBP88DoMKxsKaoa58MJM3f+V?= =?us-ascii?Q?r3H3hMZ/Ut+PBMBVgQc34ccmHEGCc8w8UyOOncaAHductzU2SfM0io8COCoS?= =?us-ascii?Q?xh50zV5SqwNNZ52S/NTrT3QCktakxjY88K+RuoJT7H+Fdzv903ot3g+bmGsH?= =?us-ascii?Q?BRMNFlpXSB7lQwSuWDXsEA6qy4AZz1U8sOuX9Dbwu8DSxXv99kyQBvnxuNwt?= =?us-ascii?Q?V7me52h3C7KwT2IzACADAU40ZsODSvrr0E78h2BSkmJwN8Guy3gq1hzfxbwV?= =?us-ascii?Q?+ayhhpMMeFwHKmduJ+3M8ZR5+dOJlbhDNfrAUn9Vso9o6NBP1mkrcXdAYZV5?= =?us-ascii?Q?e4niO/HW9OatFK/dYF6aZaQwG0hZc0VCNwgodrHfeqbUqkcfJ6UT+mswZfmu?= =?us-ascii?Q?yR2gz6BhG78MnoZqirauJFMgDP5JU6DEcQENdU72UhpchltWX2hCAveYX36v?= =?us-ascii?Q?N4QQLKL6UOnPFh4HdPBFxPSgXEcOuGp88n2tOjh7KbjGNsf81xjwPxkg/Bta?= =?us-ascii?Q?oajxbn5IZggEjUQNRcFg/pZ0qNKVIx9/LOhQLyd8NROF8uAELcRNVi+nl4a+?= =?us-ascii?Q?YHbcmLkNZ7ZGGH9rrKJVbbhXI8izo96gS6OTGHVIwfB/Bv7CZ9Spyz/q8fbq?= =?us-ascii?Q?gIDeKBwiylquZ+OTvVyaSpbUUZmQUszHCemIDyNS6Pci86RHTcoLgmo9W4HZ?= =?us-ascii?Q?Hmz0Ro30T69MvYXtKI11PtPmMI76JJs2A/28dEITpM2mKYSogOl/Cw6dXQ9J?= =?us-ascii?Q?r8NvWrOfVo12Z6aP2Mouk9NI3Kn3SSXq2d7sBqQnlx7jnEQwjwb8lAosufNI?= =?us-ascii?Q?+jcczXF6iNM8dCKdxFgfoad0uJazVgufYXmwX1pivKkxKFm+oGolT7WeyLBT?= =?us-ascii?Q?vD5H4+upqylTv5tH4Qnymp4UUB1hCPYwzoN82aBNB6R9LCATykz7Nq7r8iMX?= =?us-ascii?Q?xv/+loIfg1HYFFKEXDaT3CQgYF6XbLOTDOQIvXdklYoOEDoaRhO/ICzoQi6k?= =?us-ascii?Q?KOppZ224gZu5r8gnyNE7AE7Jc9yYSozwMms3hqPE0/YkIl5oj+LsY7+uKCfx?= =?us-ascii?Q?7gKXvuWMBjN+5RNxxnOlMIR2bhJz/zRXCk++1vH6Nf/VYIj7j3zZ1aC6aUzP?= =?us-ascii?Q?HIimFFed0u7P0bywWKQa9rmFCYtZlFoFlRqqDwcmUuCOznZtZgiS248bgDdS?= =?us-ascii?Q?GgXiJWV3xm2fHl4C77lE2K6xs3PXUPCDFsiAJXCNBad+CfbF3jtBCrxuzJkc?= =?us-ascii?Q?SdEmy+ox2RuglCHRgty+VEZ6QaCV3IbZ6gpHFeCaEEnVG27rOVmAqnSFVqMB?= =?us-ascii?Q?vaIi4aFe88O0i2gphky+lIbUW7lxb/rztIYe9SDZGo3MI3mqo1r5hc0Xuw/C?= =?us-ascii?Q?9rQ1a7+ZAC3jGXWxnGM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2eb623-b79d-46f4-c397-08da752f740c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2022 09:06:29.7097 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mNU4d8XNCd48s1qyT9Pcqz0zeqm7qV7IVEMurfdyuVOLAhSlG0wBp7OT2XwDiKEJq5Ar7xhcq1uNOTCZVD9p+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4732 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Six, Lancelot via Gdb-patches" Reply-To: "Six, Lancelot" Cc: "lsix@lancelotsix.com" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" [Public] > > "bc20e562ec0 gdb/varobj: Fix use after free in varobj" introduced a >=20 > I'd do: > ... > Commit bc20e562ec0 "gdb/varobj: Fix use after free in varobj" introduced = a > ... > in other words, start the line with a word rather than a git hash, and > do the quoting around "$subject". > [...] >=20 > stall -> stale >=20 > > >=20 > LGTM. >=20 > Thanks, > - Tom >=20 Hi, I have pushed this patch with the fixes as you suggested. Thanks, Lancelot.