Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Six, Lancelot via Gdb-patches" <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PATCH 2/2] gdb/testsuite: Accept PIE/noPIE programs in gdb.mi/mi-var-invalidate-shlib.exp
Date: Wed, 3 Aug 2022 09:35:16 +0000	[thread overview]
Message-ID: <DM4PR12MB5745FABE635835F101B69C02839C9@DM4PR12MB5745.namprd12.prod.outlook.com> (raw)
In-Reply-To: <f53bcf57-b887-348a-79a3-24345141d2f9@suse.de>

[AMD Official Use Only - General]

> Hi,
> 
> thanks for the analysis.
> 
> After looking into this a bit, I wonder if the root cause is really
> looking at the values in the old process.
> 
> Maybe we should either:
> - not try to sample the values when recreating, or
> - move the recreation to a later point when we have access to the memory
>    of the new process.
> 
> At least we would have consistency between PIE and no-PIE with either
> solution.
> 
> Thanks,
> - Tom 

Hi,

I do agree that it is strange to look for a value for the new objfile in the old process.  I wonder if there are legitimate usecases where one would want to still use "file ..." to load new symbols but keep the same process running while keeping a global varobj around.  If we delay the recreation of the varobj, we would break such usecase.

One way could be to be just invalidate the varobj when the objfile it relies on goes away and give the user a "-var-reinflate" command (or "-var-update -reinflate") so he can try to revive an invalidated varobj at his convenience.  This would break existing behavior but could avoid.

Lancelot.

  reply	other threads:[~2022-08-03  9:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 12:47 [PATCH 0/2] Fix regressions in varobj recreation Lancelot SIX via Gdb-patches
2022-08-02 12:47 ` [PATCH 1/2] gdb: Fix regression " Lancelot SIX via Gdb-patches
2022-08-02 13:26   ` Tom de Vries via Gdb-patches
2022-08-03  9:06     ` Six, Lancelot via Gdb-patches
2022-08-02 12:47 ` [PATCH 2/2] gdb/testsuite: Accept PIE/noPIE programs in gdb.mi/mi-var-invalidate-shlib.exp Lancelot SIX via Gdb-patches
2022-08-02 15:45   ` Tom de Vries via Gdb-patches
2022-08-03  9:35     ` Six, Lancelot via Gdb-patches [this message]
2022-08-03 11:51       ` Tom de Vries via Gdb-patches
2022-08-03 13:23         ` Six, Lancelot via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB5745FABE635835F101B69C02839C9@DM4PR12MB5745.namprd12.prod.outlook.com \
    --to=gdb-patches@sourceware.org \
    --cc=Lancelot.Six@amd.com \
    --cc=lsix@lancelotsix.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox