RE: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf

["Gerlicher, Klaus" <klaus.gerlicher@intel.com>]

Hi, 

Thanks for the quick response. I see, we need to include Pedro then I guess. It's 
not terribly important, I was just adding some things to breakpoint for our purposes 
and I hit this oddity.

+Pedro

Thanks
Klaus

> -----Original Message-----
> From: Kevin Buettner <kevinb@redhat.com>
> Sent: Thursday, July 10, 2025 4:59 AM
> To: Tom Tromey <tom@tromey.com>
> Cc: gdb-patches@sourceware.org; Gerlicher, Klaus
> <klaus.gerlicher@intel.com>
> Subject: Re: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf
> 
> On Wed, 09 Jul 2025 13:21:14 -0600
> Tom Tromey <tom@tromey.com> wrote:
> 
> > >>>>> "Klaus" == Klaus Gerlicher <klaus.gerlicher@intel.com> writes:
> >
> > Klaus> Some debug prints in breakpoint.c are using
> > Klaus> infrun_debug_printf ().  This does not seem to be the
> > Klaus> right debug print macro.
> >
> > Klaus> Use breakpoint_debug_printf () exclusively in this file.
> >
> > I am not so sure about this.  It seems to me that some of these may
> > mostly of interest when infrun debugging is enabled.  For example:
> >
> > Klaus> -      infrun_debug_printf ("incorrect thread or task, not
> > Klaus> stopping");
> > Klaus> +      breakpoint_debug_printf ("incorrect thread or task, not
> > Klaus> stopping");
> >
> > This kind of thing is a decision impacting infrun decisions.
> 
> Hmm, good point.  I rescind my approval.
> 
> Kevin

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928