Re: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf

[Simon Marchi <simark@simark.ca>]

On 7/10/25 4:43 AM, Gerlicher, Klaus wrote:
> Hi, 
> 
> Thanks for the quick response. I see, we need to include Pedro then I guess. It's 
> not terribly important, I was just adding some things to breakpoint for our purposes 
> and I hit this oddity.
> 
> +Pedro
> 
> Thanks
> Klaus

I agree with Tom, it's not just the file that dictates which "debug
print" function to use, it's also what the code does.  You have to ask
yourself, when would I want to see this debug print.  This is how I see
it:

 - "infrun" is about GDB controlling the threads, handling target
   events, resuming threads, stopping threads, etc.
 - "breakpoint" is about the actions of inserting or removing
   breakpoints, computing the locations of breakpoints, etc.

You have to ask yourself, when would you like to see each statement.
The code in bpstat_check_breakpoint_conditions, for instance, is about
evaluating a breakpoint condition after a thread has hit it.  I think
these debug prints are useful to have when debugging infrun issues,
when you ask yourself "why did GDB decide to stop/not stop this thread".

It's possible that some of these infrun prints should be breakpoint
prints, but it needs to be more thought out.

I see that breakpoint_debug_printf is only used at 5 spots, which is
surprising, since the breakpoint machinery is rather complex and core to
GDB.  It is relatively recent (2023), so it perhaps just means we need
to add more of them, when we debug issues.

Simon