Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Klaus Gerlicher <klaus.gerlicher@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf
Date: Wed, 09 Jul 2025 13:21:14 -0600	[thread overview]
Message-ID: <87zfddcgr9.fsf@tromey.com> (raw)
In-Reply-To: <20250708132123.561491-1-klaus.gerlicher@intel.com> (Klaus Gerlicher's message of "Tue, 8 Jul 2025 13:21:23 +0000")

>>>>> "Klaus" == Klaus Gerlicher <klaus.gerlicher@intel.com> writes:

Klaus> Some debug prints in breakpoint.c are using
Klaus> infrun_debug_printf ().  This does not seem to be the
Klaus> right debug print macro.

Klaus> Use breakpoint_debug_printf () exclusively in this file.

I am not so sure about this.  It seems to me that some of these may
mostly of interest when infrun debugging is enabled.  For example:

Klaus> -      infrun_debug_printf ("incorrect thread or task, not stopping");
Klaus> +      breakpoint_debug_printf ("incorrect thread or task, not stopping");

This kind of thing is a decision impacting infrun decisions.

However I would defer to Pedro in this matter since he works on infrun
more than anyone else seems to.

thanks,
Tom

  parent reply	other threads:[~2025-07-09 19:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 13:21 Klaus Gerlicher
2025-07-08 15:46 ` Kevin Buettner
2025-07-09 19:21 ` Tom Tromey [this message]
2025-07-10  2:58   ` Kevin Buettner
2025-07-10  8:43     ` Gerlicher, Klaus
2025-07-11 15:22       ` Simon Marchi
2025-07-17 17:02       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfddcgr9.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=klaus.gerlicher@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox