Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Khoo Yit Phang <khooyp@cs.umd.edu>
To: Tom Tromey <tromey@redhat.com>
Cc: Khoo Yit Phang <khooyp@cs.umd.edu>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] Make python/lib/gdb and submodules proper Python modules
Date: Thu, 13 Sep 2012 21:51:00 -0000	[thread overview]
Message-ID: <D912CDCF-BB08-40FA-9514-95A36D45D255@cs.umd.edu> (raw)
In-Reply-To: <87zk4t1w1z.fsf@fleche.redhat.com>

Hi Tom,

On Sep 13, 2012, at 4:56 PM, Tom Tromey wrote:

>>>>>> "Yit" == Khoo Yit Phang <khooyp@cs.umd.edu> writes:
> 
> Yit> Thanks for the review. I've attached an updated patch that restores
> Yit> PYTHONDIR and fixes the formatting. Also, is there a particular
> Yit> preferred style for the Python code? Most of the code under
> Yit> gdb/python/lib/gdb seem to conform to PEP 8 (no tabs, 4-space indents,
> Yit> no space before parentheses) rather than the GNU style. So I've
> Yit> reformatted the "gdb" module to PEP 8 too.
> 
> Yeah, I believe we agreed on following PEP 8 for the Python code.  Maybe
> we did this after writing a chunk of the code, though, so it may not all
> be consistent.
> 
> Your patch is ok.  Thanks for doing this.

Thanks, I've checked in the patch.

Yit
September 13, 2012


  reply	other threads:[~2012-09-13 21:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03  3:44 Khoo Yit Phang
2012-09-07  6:19 ` Doug Evans
2012-09-07 14:27   ` Khoo Yit Phang
2012-09-10 20:38 ` Tom Tromey
2012-09-12 20:00   ` Khoo Yit Phang
2012-09-13 20:56     ` Tom Tromey
2012-09-13 21:51       ` Khoo Yit Phang [this message]
2012-09-14  5:48         ` Regression for --batch [Re: [RFC] Make python/lib/gdb and submodules proper Python modules] Jan Kratochvil
2012-09-14  6:00           ` Khoo Yit Phang
2012-09-14  6:16             ` Jan Kratochvil
2012-09-14  6:26               ` Khoo Yit Phang
2012-09-14  6:37                 ` Jan Kratochvil
2012-09-14  6:53                   ` Khoo Yit Phang
2012-09-14  7:04                     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D912CDCF-BB08-40FA-9514-95A36D45D255@cs.umd.edu \
    --to=khooyp@cs.umd.edu \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox