From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16552 invoked by alias); 13 Sep 2012 21:51:32 -0000 Received: (qmail 16341 invoked by uid 22791); 13 Sep 2012 21:51:30 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Sep 2012 21:51:15 +0000 Received: from [10.109.163.21] (129-2-129-152.wireless.umd.edu [129.2.129.152]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id 3B9CCB403DA; Thu, 13 Sep 2012 17:51:13 -0400 (EDT) Subject: Re: [RFC] Make python/lib/gdb and submodules proper Python modules Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Khoo Yit Phang In-Reply-To: <87zk4t1w1z.fsf@fleche.redhat.com> Date: Thu, 13 Sep 2012 21:51:00 -0000 Cc: Khoo Yit Phang , GDB Patches Content-Transfer-Encoding: 7bit Message-Id: References: <87obldbom1.fsf@fleche.redhat.com> <446971D4-9F73-4CD9-B307-C22D4C079305@cs.umd.edu> <87zk4t1w1z.fsf@fleche.redhat.com> To: Tom Tromey X-CSD-MailScanner-ID: 3B9CCB403DA.A0D09 X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1348177873.27652@1NeM9c1Of0FZHZ5MtcsFXw Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00256.txt.bz2 Hi Tom, On Sep 13, 2012, at 4:56 PM, Tom Tromey wrote: >>>>>> "Yit" == Khoo Yit Phang writes: > > Yit> Thanks for the review. I've attached an updated patch that restores > Yit> PYTHONDIR and fixes the formatting. Also, is there a particular > Yit> preferred style for the Python code? Most of the code under > Yit> gdb/python/lib/gdb seem to conform to PEP 8 (no tabs, 4-space indents, > Yit> no space before parentheses) rather than the GNU style. So I've > Yit> reformatted the "gdb" module to PEP 8 too. > > Yeah, I believe we agreed on following PEP 8 for the Python code. Maybe > we did this after writing a chunk of the code, though, so it may not all > be consistent. > > Your patch is ok. Thanks for doing this. Thanks, I've checked in the patch. Yit September 13, 2012