Re: [RFC] Make python/lib/gdb and submodules proper Python modules

Khoo Yit Phang
2012-09-13T21:51:32Z

Hi Tom,

On Sep 13, 2012, at 4:56 PM, Tom Tromey wrote:

>>>>>> "Yit" == Khoo Yit Phang <khooyp@cs.umd.edu> writes:
>
> Yit> Thanks for the review. I've attached an updated patch that restores
> Yit> PYTHONDIR and fixes the formatting. Also, is there a particular
> Yit> preferred style for the Python code? Most of the code under
> Yit> gdb/python/lib/gdb seem to conform to PEP 8 (no tabs, 4-space indents,
> Yit> no space before parentheses) rather than the GNU style. So I've
> Yit> reformatted the "gdb" module to PEP 8 too.
>
> Yeah, I believe we agreed on following PEP 8 for the Python code. Maybe
> we did this after writing a chunk of the code, though, so it may not all
> be consistent.
>
> Your patch is ok. Thanks for doing this.

Thanks, I've checked in the patch.

Yit
September 13, 2012