From: Alan Hayward <Alan.Hayward@arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"vapier@gentoo.org" <vapier@gentoo.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from remote-sim.c
Date: Tue, 27 Jun 2017 12:14:00 -0000 [thread overview]
Message-ID: <CCE57C3E-4BD0-415E-900C-4AF8C5EE0BB5@arm.com> (raw)
In-Reply-To: <86fuelg0k1.fsf@gmail.com>
> On 27 Jun 2017, at 11:57, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> Alan Hayward <Alan.Hayward@arm.com> writes:
>
> Patch is good to me.
>
>> if (nr_bytes > 0
>> - && nr_bytes != register_size (gdbarch, regno) && warn_user)
>> + && nr_bytes != regsize && warn_user)
>> {
>
> A nit, can you put them in a single line?
>
> --
> Yao (齐尧)
Pushed with the above IF on a single line.
Alan.
prev parent reply other threads:[~2017-06-27 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 10:03 Alan Hayward
2017-03-23 14:12 ` Alan Hayward
[not found] ` <86wpbft0r4.fsf@gmail.com>
2017-03-24 11:41 ` Alan Hayward
[not found] ` <E7F813B0-BCB9-464C-BD4C-95F0A3D789E1@arm.com>
[not found] ` <CAH=s-POSw=RatBGkLmryoAR4eN880nzxW+zt-p_TOuPMq8RRaw@mail.gmail.com>
2017-06-26 12:41 ` Alan Hayward
2017-06-27 10:57 ` Yao Qi
2017-06-27 12:14 ` Alan Hayward [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCE57C3E-4BD0-415E-900C-4AF8C5EE0BB5@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=qiyaoltc@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox