Re: [PATCH] Remove MAX_REGISTER_SIZE from remote-sim.c

Alan Hayward
2017-03-24T11:41:38Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 834 bytes --]

> On 24 Mar 2017, at 10:41, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> Alan Hayward <Alan.Hayward@arm.com> writes:
>
>> Used a std::vector in the first case and struct value in the second.
>>
>> Tested using make check with board files unix and native-gdbserver.
>>
>
> What is your target triplet? Do you see remote-sim.o in your build
> directory? remote-sim.c may not be built at all.

You’re correct - I’m not building remote-sim at all!
Forcing SIM_OBS in Makefile.in gives me a compile error (just need to
cast result of value_contents_all to remove the const).

Is there an easy way to build and test remote-sim ?

>
>> Ok to commit?
>>
>
> It is good to me. This patch is related to SIM, so I'd like Mike to
> take a look too.
>
> --
> Yao (é½å°§)

\x16º&Öéj×!zÊÞ¶êç×~ûóÙb²Ö«r\x18\x1dn–­r\x17¬