Re: [PATCH] Ignore the first entry returned by svr4_current_sos_via_xfer_libraries for dynamically linked programs

[Ben Cheng <bccheng@google.com>]

Hi Jan,

Hope the copyright assignment issue has been taken care now. And
thanks for taking care of the formatting changes.

Thanks,
-Ben

On Tue, Jun 4, 2013 at 1:58 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hello Ben,
>
> the patch looks fine but I do not see GDB copyright assignment either yours or
> a Google global one.  Hopefully this patch is small enough to need one.
>
> I will check it in reformatted after possibly copyright assignment reply.
>
>
> On Tue, 28 May 2013 20:31:31 +0200, Ben Cheng wrote:
>> <       return library_list.head ? library_list.head : svr4_default_sos ();
>> ---
>> >       /* Use the same logic that determines the 'ignore_first' variable
>> >          below. PR - 15507 */
>
> There should be two spaces between . and */ so that PR could be for example in
> parentheses.
>
>
>> >       if (exec_bfd && bfd_get_section_by_name (exec_bfd, ".dynamic") == NULL)
>> >     return library_list.head ? library_list.head : svr4_default_sos ();
>> >       else
>> >     return library_list.head && library_list.head->next ?
>> >       library_list.head->next : svr4_default_sos ();
>
> http://www.gnu.org/prep/standards/standards.html formatting says:
>         return (library_list.head && library_list.head->next
>                 ? library_list.head->next : svr4_default_sos ());
>
>
> Thanks,
> Jan