Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ben Cheng <bccheng@google.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Ignore the first entry returned by svr4_current_sos_via_xfer_libraries for dynamically linked programs
Date: Tue, 28 May 2013 18:31:00 -0000	[thread overview]
Message-ID: <CAPk6zkCTrkS960JAG70PdTaTAE=FQ1y4V2CneiNutSu6CG8rwA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

The first entry in the xml list returned by
svr4_current_sos_via_xfer_libraries() is the executable itself. For
dynamically linked programs, the existing code that deals with
gdbserver that doesn't support svr4_current_sos_via_xfer_libraries is
ignoring the first entry. This patch applies the same logic on the
result returned by svr4_current_sos_via_xfer_libraries().

See GDB PR/15507 for more details.

--

2013-05-28  Ben Cheng  <bccheng@android.com>

    PR gdb/15507:
    * solib-svr4.c (svr4_current_sos): Ignore the first library list
    entry returned by svr4_current_sos_via_xfer_libraries call for
    dynamically linked programs.

[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 656 bytes --]

Index: solib-svr4.c
===================================================================
RCS file: /cvs/src/src/gdb/solib-svr4.c,v
retrieving revision 1.178
diff -r1.178 solib-svr4.c
1285c1285,1291
<       return library_list.head ? library_list.head : svr4_default_sos ();
---
>       /* Use the same logic that determines the 'ignore_first' variable
>          below. PR - 15507 */
>       if (exec_bfd && bfd_get_section_by_name (exec_bfd, ".dynamic") == NULL)
> 	return library_list.head ? library_list.head : svr4_default_sos ();
>       else
> 	return library_list.head && library_list.head->next ?
> 	  library_list.head->next : svr4_default_sos ();

             reply	other threads:[~2013-05-28 18:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 18:31 Ben Cheng [this message]
2013-05-29 10:17 ` Gary Benson
2013-06-04  8:58 ` Jan Kratochvil
2013-06-04 17:19   ` Ben Cheng
2013-06-04 18:07 ` Jan Kratochvil
2013-06-04 18:18   ` Ben Cheng
2013-06-04 20:23     ` Jan Kratochvil
2013-06-04 20:36       ` Ben Cheng
2013-06-04 20:45         ` Ben Cheng
2013-06-04 20:57           ` Jan Kratochvil
2013-06-04 21:21             ` Ben Cheng
2013-06-05 11:38               ` [patchv2] " Jan Kratochvil
     [not found]                 ` <51AF4C5B.5080104@redhat.com>
2013-06-09 18:08                   ` [commit] " Jan Kratochvil
2013-06-11  6:32                     ` Ben Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPk6zkCTrkS960JAG70PdTaTAE=FQ1y4V2CneiNutSu6CG8rwA@mail.gmail.com' \
    --to=bccheng@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox