From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7371 invoked by alias); 4 Jun 2013 17:19:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7356 invoked by uid 89); 4 Jun 2013 17:19:00 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ob0-f174.google.com (HELO mail-ob0-f174.google.com) (209.85.214.174) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 04 Jun 2013 17:18:59 +0000 Received: by mail-ob0-f174.google.com with SMTP id wd20so862663obb.5 for ; Tue, 04 Jun 2013 10:18:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=EtbQS4SkoB2/uTWbYoAeIyxXO0Mc2c2z4xMIz7cODRw=; b=Vq5xUx+6XoPgl4TobpNbXYZoBYwhEUUrjumDQhQXjTuht/hzzfRhtvoq/hX9qXPEbW Ixtc2Q1xlVxminhFDeuYISn3fe85lnE72llBzqHfmN8MAkEnhxdaoUIsSSBp7CD+1z6V tXKFc8A1gase7jkNjTN4dv1cKcKCp4ensCTqZlx1F7hFDySrJMObKcMMvxDKmgz6Im7S G09Q12gZ7YM2bmuVPEv63ayVpQLXGyBNhotv0hb3baJDXkEOhPNwNcFQG6SlwQ9NB5J6 5/MVaADGlyImJebFwq45xG8MkQa8M0/k/cgHZyZhQ/MSF0GDhc054F93NweTQLtmWRgR 3dzA== MIME-Version: 1.0 X-Received: by 10.182.87.170 with SMTP id az10mr12647021obb.10.1370366338095; Tue, 04 Jun 2013 10:18:58 -0700 (PDT) Received: by 10.182.22.49 with HTTP; Tue, 4 Jun 2013 10:18:58 -0700 (PDT) In-Reply-To: <20130604085821.GA6431@host2.jankratochvil.net> References: <20130604085821.GA6431@host2.jankratochvil.net> Date: Tue, 04 Jun 2013 17:19:00 -0000 Message-ID: Subject: Re: [PATCH] Ignore the first entry returned by svr4_current_sos_via_xfer_libraries for dynamically linked programs From: Ben Cheng To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQl9EihdQvLcq9N+f0XRRPHqzWw/Ev8Qzpnb5o0MrYQcA/PVZkSQt6ap2aZ+gAsRlg6VB2sSoSfhgE6qbDuGTMd/WHystIVRe3X9yFNaZHpHErcmt22rvEuPs1izptpufslC3TBOZ0StUQJX2Eltt3p7drJWGCyqht8binTMkC6yuBXnmEUtmcpwBbYRi4DmYEqEa3DVM8rWX5+ILSn8xMtlqfprYA== X-SW-Source: 2013-06/txt/msg00051.txt.bz2 Hi Jan, Hope the copyright assignment issue has been taken care now. And thanks for taking care of the formatting changes. Thanks, -Ben On Tue, Jun 4, 2013 at 1:58 AM, Jan Kratochvil wrote: > Hello Ben, > > the patch looks fine but I do not see GDB copyright assignment either yours or > a Google global one. Hopefully this patch is small enough to need one. > > I will check it in reformatted after possibly copyright assignment reply. > > > On Tue, 28 May 2013 20:31:31 +0200, Ben Cheng wrote: >> < return library_list.head ? library_list.head : svr4_default_sos (); >> --- >> > /* Use the same logic that determines the 'ignore_first' variable >> > below. PR - 15507 */ > > There should be two spaces between . and */ so that PR could be for example in > parentheses. > > >> > if (exec_bfd && bfd_get_section_by_name (exec_bfd, ".dynamic") == NULL) >> > return library_list.head ? library_list.head : svr4_default_sos (); >> > else >> > return library_list.head && library_list.head->next ? >> > library_list.head->next : svr4_default_sos (); > > http://www.gnu.org/prep/standards/standards.html formatting says: > return (library_list.head && library_list.head->next > ? library_list.head->next : svr4_default_sos ()); > > > Thanks, > Jan