From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add block['var'] accessor
Date: Mon, 05 Aug 2019 18:20:00 -0000 [thread overview]
Message-ID: <CAPTJ0XHUOSEh-8fbwvTgcp7q8Wr8c8xc5Kopd6yTTL_r6JnBzw@mail.gmail.com> (raw)
In-Reply-To: <6f69d3a0-e977-71c3-bcf3-dd619cd4cf99@simark.ca>
On Mon, Aug 5, 2019 at 1:17 PM Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-08-02 9:36 a.m., Tom Tromey wrote:
> > Christian> + struct symbol *sym = block_lookup_symbol (
> > Christian> + block, name.get(), symbol_name_match_type::FULL, VAR_DOMAIN);
> >
> > What about looking up things in other domains? I wonder if it's
> > possible to, say, have a local type that can be found by iteration over
> > the block but not by dictionary access. If so, that seems confusing.
>
> Just wondering, was this commented responded to?
Oh sorry, in the most recent version of the patch I fixed it by using
ALL_BLOCK_SYMBOLS_WITH_NAME, which should match the behavior of the
iterator afaict.
Christian
next prev parent reply other threads:[~2019-08-05 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 22:34 Christian Biesinger via gdb-patches
2019-08-02 7:01 ` Eli Zaretskii
2019-08-02 13:36 ` Tom Tromey
2019-08-02 23:11 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-08-05 17:34 ` Tom Tromey
2019-08-05 18:08 ` Christian Biesinger via gdb-patches
2019-08-05 18:17 ` [PATCH] " Simon Marchi
2019-08-05 18:20 ` Christian Biesinger via gdb-patches [this message]
2019-08-05 18:28 ` Simon Marchi
2019-08-05 18:30 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XHUOSEh-8fbwvTgcp7q8Wr8c8xc5Kopd6yTTL_r6JnBzw@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox