From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42134 invoked by alias); 5 Aug 2019 18:20:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42126 invoked by uid 89); 5 Aug 2019 18:20:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.7 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:736, FULL X-HELO: mail-ot1-f65.google.com Received: from mail-ot1-f65.google.com (HELO mail-ot1-f65.google.com) (209.85.210.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Aug 2019 18:20:17 +0000 Received: by mail-ot1-f65.google.com with SMTP id r6so86193291oti.3 for ; Mon, 05 Aug 2019 11:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NmEsVup4Mak0uN06byfoARZki1ADDS9g1Fl8OwujhbA=; b=pYW37D9HX9SPPLvvq9/x1/63zYmf615wn3wKjGad3+CFcxBoRMtBdSox4R7DF3M7IA UacRv2aakVXxVIKUAop39j6VCOhyAvqwWDr3ASvBiVxAPeEK/L6lkFFpkZtvs0XVdznd XP4+u/a9uG0utj6ALr7NV7k31ex0XKjxgfdf6AHnHTa6vmrwmHReIsM2NqwU6dMnqGku 3tSnlFfFY8Yw/VMbNHgiHLXitLgKsPQ/v93K3D5Qvhhx5wKa6YOFLCfXCJcziYWqO7TD C+9nlxauxP76JwXWml3mrez6QvMdmr4wuPhMewUa5AEFWIz11QUB6Y4Yd38OrIWxbx2p 7LGw== MIME-Version: 1.0 References: <20190801223420.234581-1-cbiesinger@google.com> <87y30bit95.fsf@tromey.com> <6f69d3a0-e977-71c3-bcf3-dd619cd4cf99@simark.ca> In-Reply-To: <6f69d3a0-e977-71c3-bcf3-dd619cd4cf99@simark.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Mon, 05 Aug 2019 18:20:00 -0000 Message-ID: Subject: Re: [PATCH] Add block['var'] accessor To: Simon Marchi Cc: Tom Tromey , Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-08/txt/msg00122.txt.bz2 On Mon, Aug 5, 2019 at 1:17 PM Simon Marchi wrote: > > On 2019-08-02 9:36 a.m., Tom Tromey wrote: > > Christian> + struct symbol *sym = block_lookup_symbol ( > > Christian> + block, name.get(), symbol_name_match_type::FULL, VAR_DOMAIN); > > > > What about looking up things in other domains? I wonder if it's > > possible to, say, have a local type that can be found by iteration over > > the block but not by dictionary access. If so, that seems confusing. > > Just wondering, was this commented responded to? Oh sorry, in the most recent version of the patch I fixed it by using ALL_BLOCK_SYMBOLS_WITH_NAME, which should match the behavior of the iterator afaict. Christian