Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add block['var'] accessor
Date: Fri, 02 Aug 2019 07:01:00 -0000	[thread overview]
Message-ID: <835znggifb.fsf@gnu.org> (raw)
In-Reply-To: <20190801223420.234581-1-cbiesinger@google.com>	(gdb-patches@sourceware.org)

> Date: Thu,  1 Aug 2019 17:34:20 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
> 
> Currently we support iteration on blocks; this patch extends that to make
> subscript access work as well.
> 
> gdb/ChangeLog:
> 
> 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* NEWS: Mention dictionary access on blocks.
> 	* python/py-block.c (blpy_getitem): New function.
>   (block_object_as_mapping): New struct.
>   (block_object_type): Use new struct for tp_as_mapping field.
> 
> gdb/doc/ChangeLog:
> 
> 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* python.texi (Blocks In Python): Document dictionary access on blocks.
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* gdb.python/py-block.exp: Test dictionary access on blocks.

OK for the documentation parts, thanks.


  reply	other threads:[~2019-08-02  7:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 22:34 Christian Biesinger via gdb-patches
2019-08-02  7:01 ` Eli Zaretskii [this message]
2019-08-02 13:36 ` Tom Tromey
2019-08-02 23:11   ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-08-05 17:34     ` Tom Tromey
2019-08-05 18:08       ` Christian Biesinger via gdb-patches
2019-08-05 18:17   ` [PATCH] " Simon Marchi
2019-08-05 18:20     ` Christian Biesinger via gdb-patches
2019-08-05 18:28       ` Simon Marchi
2019-08-05 18:30         ` Christian Biesinger via gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835znggifb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox