From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157902-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 44492 invoked by alias); 2 Aug 2019 07:01:21 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 44480 invoked by uid 89); 2 Aug 2019 07:01:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Aug 2019 07:01:19 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51006)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1htRZ0-0006BC-00; Fri, 02 Aug 2019 03:01:18 -0400
Received: from [176.228.60.248] (port=3287 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1htRYz-0001n3-D7; Fri, 02 Aug 2019 03:01:17 -0400
Date: Fri, 02 Aug 2019 07:01:00 -0000
Message-Id: <835znggifb.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
CC: gdb-patches@sourceware.org
In-reply-to: <20190801223420.234581-1-cbiesinger@google.com>	(gdb-patches@sourceware.org)
Subject: Re: [PATCH] Add block['var'] accessor
References: <20190801223420.234581-1-cbiesinger@google.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-08/txt/msg00039.txt.bz2

> Date: Thu,  1 Aug 2019 17:34:20 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
> 
> Currently we support iteration on blocks; this patch extends that to make
> subscript access work as well.
> 
> gdb/ChangeLog:
> 
> 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* NEWS: Mention dictionary access on blocks.
> 	* python/py-block.c (blpy_getitem): New function.
>   (block_object_as_mapping): New struct.
>   (block_object_type): Use new struct for tp_as_mapping field.
> 
> gdb/doc/ChangeLog:
> 
> 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* python.texi (Blocks In Python): Document dictionary access on blocks.
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* gdb.python/py-block.exp: Test dictionary access on blocks.

OK for the documentation parts, thanks.