Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Convert symtab.h function signatures to use bool instead of int
Date: Thu, 26 Sep 2019 16:37:00 -0000	[thread overview]
Message-ID: <CAPTJ0XH8abiAyOb7s1p8JSzSW=m4u_a3pSj6PaxeLx_yqb=weg@mail.gmail.com> (raw)
In-Reply-To: <87h84zgh9h.fsf@tromey.com>

On Thu, Sep 26, 2019 at 11:21 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> gdb/ChangeLog:
> Christian> 2019-09-24  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * blockframe.c (find_pc_partial_function): Change return type to bool.
> Christian>      * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
> Christian>      * minsyms.c (in_gnu_ifunc_stub): Likewise.
> Christian>      (stub_gnu_ifunc_resolve_name): Likewise.
> Christian>      * symtab.c (compare_filenames_for_search): Likewise.
> Christian>      (compare_glob_filenames_for_search): Likewise.
> Christian>      (matching_obj_sections): Likewise.
> Christian>      (symbol_matches_domain): Likewise.
> Christian>      (find_line_symtab): Change out param EXACT_MATCH to bool *.
> Christian>      (find_line_pc): Change return type to bool.
> Christian>      (find_line_pc_range): Likewise.
> Christian>      (producer_is_realview): Likewise.
> Christian>      * symtab.h (symbol_matches_domain): Likewise.
> Christian>      (find_pc_partial_function): Likewise.
> Christian>      (find_pc_line_pc_range): Likewise.
> Christian>      (in_gnu_ifunc_stub): Likewise.
> Christian>      (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
> Christian>      (find_line_pc): Likewise.
> Christian>      (find_line_pc_range): Likewise.
> Christian>      (matching_obj_sections): Likewise.
> Christian>      (find_line_symtab): Change out parameter to bool.
> Christian>      (producer_is_realview): Change return type to bool.
> Christian>      (compare_filenames_for_search): Likewise.
> Christian>      (compare_glob_filenames_for_search): Likewise.
>
> Thank you for doing this.
> This is ok.

Thanks, pushed

To ssh://sourceware.org/git/binutils-gdb.git
   27a900b865..ececd218c5  HEAD -> master

Christian


      reply	other threads:[~2019-09-26 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 21:53 Christian Biesinger via gdb-patches
2019-09-26 16:21 ` Tom Tromey
2019-09-26 16:37   ` Christian Biesinger via gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPTJ0XH8abiAyOb7s1p8JSzSW=m4u_a3pSj6PaxeLx_yqb=weg@mail.gmail.com' \
    --to=gdb-patches@sourceware.org \
    --cc=cbiesinger@google.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox