From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110228 invoked by alias); 26 Sep 2019 16:37:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110220 invoked by uid 89); 26 Sep 2019 16:37:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.1 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=UD:binutils-gdb.git X-HELO: mail-ot1-f65.google.com Received: from mail-ot1-f65.google.com (HELO mail-ot1-f65.google.com) (209.85.210.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 16:37:53 +0000 Received: by mail-ot1-f65.google.com with SMTP id o44so2561539ota.10 for ; Thu, 26 Sep 2019 09:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L8cxPk8peMT70zO0KSKfzN0d/Rm8fZnRKup8c9jD3I0=; b=kS5fhug/AF7JJNDh1JbPKuza8KYMnyGJj6GHemybqFez2LOFjH9KnLY9arJQJnbRNa xxMb5wgSIdf07lk6wVJ1OvME03yqLNXI06n2n4tbFgnvsU4PpzqQ7MW31gA8W4l7WQWP tvs4e1dCjEIiJGeBrPjODesPOA3jMGgcM4QSjkwv8I9Ta0h5f9Uz8ikTf1dPwxVmWajG +8sUIjgXOlXjmXSORxiQm78rkRihnWI6eOJ9PryHw6lPnnkCDVmJxBv+Waf91fV73dwF fnWVDw47UcLhuaFZRxRzsA5QMO1+T2kQiib9oW9LCOl5m01X4fxYgcZp1vXechcTABCE Nh/g== MIME-Version: 1.0 References: <20190924215341.40236-1-cbiesinger@google.com> <87h84zgh9h.fsf@tromey.com> In-Reply-To: <87h84zgh9h.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 26 Sep 2019 16:37:00 -0000 Message-ID: Subject: Re: [PATCH] Convert symtab.h function signatures to use bool instead of int To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00531.txt.bz2 On Thu, Sep 26, 2019 at 11:21 AM Tom Tromey wrote: > > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > Christian> gdb/ChangeLog: > Christian> 2019-09-24 Christian Biesinger > > Christian> * blockframe.c (find_pc_partial_function): Change return type to bool. > Christian> * elfread.c (elf_gnu_ifunc_resolve_name): Likewise. > Christian> * minsyms.c (in_gnu_ifunc_stub): Likewise. > Christian> (stub_gnu_ifunc_resolve_name): Likewise. > Christian> * symtab.c (compare_filenames_for_search): Likewise. > Christian> (compare_glob_filenames_for_search): Likewise. > Christian> (matching_obj_sections): Likewise. > Christian> (symbol_matches_domain): Likewise. > Christian> (find_line_symtab): Change out param EXACT_MATCH to bool *. > Christian> (find_line_pc): Change return type to bool. > Christian> (find_line_pc_range): Likewise. > Christian> (producer_is_realview): Likewise. > Christian> * symtab.h (symbol_matches_domain): Likewise. > Christian> (find_pc_partial_function): Likewise. > Christian> (find_pc_line_pc_range): Likewise. > Christian> (in_gnu_ifunc_stub): Likewise. > Christian> (struct gnu_ifunc_fns) : Likewise. > Christian> (find_line_pc): Likewise. > Christian> (find_line_pc_range): Likewise. > Christian> (matching_obj_sections): Likewise. > Christian> (find_line_symtab): Change out parameter to bool. > Christian> (producer_is_realview): Change return type to bool. > Christian> (compare_filenames_for_search): Likewise. > Christian> (compare_glob_filenames_for_search): Likewise. > > Thank you for doing this. > This is ok. Thanks, pushed To ssh://sourceware.org/git/binutils-gdb.git 27a900b865..ececd218c5 HEAD -> master Christian