From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] Convert symtab.h function signatures to use bool instead of int
Date: Thu, 26 Sep 2019 16:21:00 -0000 [thread overview]
Message-ID: <87h84zgh9h.fsf@tromey.com> (raw)
In-Reply-To: <20190924215341.40236-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 24 Sep 2019 16:53:41 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> gdb/ChangeLog:
Christian> 2019-09-24 Christian Biesinger <cbiesinger@google.com>
Christian> * blockframe.c (find_pc_partial_function): Change return type to bool.
Christian> * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
Christian> * minsyms.c (in_gnu_ifunc_stub): Likewise.
Christian> (stub_gnu_ifunc_resolve_name): Likewise.
Christian> * symtab.c (compare_filenames_for_search): Likewise.
Christian> (compare_glob_filenames_for_search): Likewise.
Christian> (matching_obj_sections): Likewise.
Christian> (symbol_matches_domain): Likewise.
Christian> (find_line_symtab): Change out param EXACT_MATCH to bool *.
Christian> (find_line_pc): Change return type to bool.
Christian> (find_line_pc_range): Likewise.
Christian> (producer_is_realview): Likewise.
Christian> * symtab.h (symbol_matches_domain): Likewise.
Christian> (find_pc_partial_function): Likewise.
Christian> (find_pc_line_pc_range): Likewise.
Christian> (in_gnu_ifunc_stub): Likewise.
Christian> (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
Christian> (find_line_pc): Likewise.
Christian> (find_line_pc_range): Likewise.
Christian> (matching_obj_sections): Likewise.
Christian> (find_line_symtab): Change out parameter to bool.
Christian> (producer_is_realview): Change return type to bool.
Christian> (compare_filenames_for_search): Likewise.
Christian> (compare_glob_filenames_for_search): Likewise.
Thank you for doing this.
This is ok.
Tom
next prev parent reply other threads:[~2019-09-26 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 21:53 Christian Biesinger via gdb-patches
2019-09-26 16:21 ` Tom Tromey [this message]
2019-09-26 16:37 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h84zgh9h.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox