From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116239 invoked by alias); 26 Sep 2019 16:21:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116231 invoked by uid 89); 26 Sep 2019 16:21:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 16:21:49 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 5A8BE3914E7 for ; Thu, 26 Sep 2019 11:21:48 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DWWZiJlZ6BnGaDWWZiVKIi; Thu, 26 Sep 2019 11:21:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yZvB57T2cjA8SoAvuawxEvQufFKaY/ZjuzEXuYRoGFE=; b=BGH8W0gHeq89B3vKWRPGMXmZ2J 4vuhvlFvLHXtg+Du65c0bbQWgTGs/KTsCXMJiK98ZzSkMJNEbVNe7+9tgY6uMOfS3cpk6eaClK8wC KHy/2GCUHAWXA3/eR2gpB0H8H; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:49312 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iDWWZ-00239r-MN; Thu, 26 Sep 2019 11:21:47 -0500 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Convert symtab.h function signatures to use bool instead of int References: <20190924215341.40236-1-cbiesinger@google.com> Date: Thu, 26 Sep 2019 16:21:00 -0000 In-Reply-To: <20190924215341.40236-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Tue, 24 Sep 2019 16:53:41 -0500") Message-ID: <87h84zgh9h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00530.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> gdb/ChangeLog: Christian> 2019-09-24 Christian Biesinger Christian> * blockframe.c (find_pc_partial_function): Change return type to bool. Christian> * elfread.c (elf_gnu_ifunc_resolve_name): Likewise. Christian> * minsyms.c (in_gnu_ifunc_stub): Likewise. Christian> (stub_gnu_ifunc_resolve_name): Likewise. Christian> * symtab.c (compare_filenames_for_search): Likewise. Christian> (compare_glob_filenames_for_search): Likewise. Christian> (matching_obj_sections): Likewise. Christian> (symbol_matches_domain): Likewise. Christian> (find_line_symtab): Change out param EXACT_MATCH to bool *. Christian> (find_line_pc): Change return type to bool. Christian> (find_line_pc_range): Likewise. Christian> (producer_is_realview): Likewise. Christian> * symtab.h (symbol_matches_domain): Likewise. Christian> (find_pc_partial_function): Likewise. Christian> (find_pc_line_pc_range): Likewise. Christian> (in_gnu_ifunc_stub): Likewise. Christian> (struct gnu_ifunc_fns) : Likewise. Christian> (find_line_pc): Likewise. Christian> (find_line_pc_range): Likewise. Christian> (matching_obj_sections): Likewise. Christian> (find_line_symtab): Change out parameter to bool. Christian> (producer_is_realview): Change return type to bool. Christian> (compare_filenames_for_search): Likewise. Christian> (compare_glob_filenames_for_search): Likewise. Thank you for doing this. This is ok. Tom