Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>
Cc: Pedro Alves <palves@redhat.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix build failure on macOS
Date: Wed, 18 Dec 2019 19:18:00 -0000	[thread overview]
Message-ID: <CAPTJ0XGMhMO=n6Fg9Z8-oHQBg60oftwnDWYELyEbGXitgpQR0A@mail.gmail.com> (raw)
In-Reply-To: <87pngloala.fsf@tromey.com>

On Wed, Dec 18, 2019 at 10:35 AM Tom Tromey <tromey@adacore.com> wrote:
> --- a/gdb/ui-out.h
> +++ b/gdb/ui-out.h
> @@ -77,8 +77,11 @@ enum ui_out_type
>  /* The possible kinds of fields.  */
>  enum class field_kind
>    {
> -    SIGNED,
> -    STRING,
> +    /* "FIELD_STRING" needs has a funny name to avoid clashes with

Remove either "needs" or "has"?

It is very unfortunate that a member of an enum class will need a
prefix, since the entire point of an enum class is not to need that :(

Christian


  parent reply	other threads:[~2019-12-18 19:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 15:05 Tom Tromey
2019-12-18 16:21 ` Pedro Alves
2019-12-18 16:35   ` Tom Tromey
2019-12-18 16:38     ` Pedro Alves
2019-12-18 19:18     ` Christian Biesinger via gdb-patches [this message]
2019-12-19 18:11       ` Tom Tromey
2019-12-18 16:32 ` Simon Marchi
2019-12-18 16:37   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPTJ0XGMhMO=n6Fg9Z8-oHQBg60oftwnDWYELyEbGXitgpQR0A@mail.gmail.com' \
    --to=gdb-patches@sourceware.org \
    --cc=cbiesinger@google.com \
    --cc=palves@redhat.com \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox