From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>,
Christian Biesinger <cbiesinger@google.com>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Fix build failure on macOS
Date: Thu, 19 Dec 2019 18:11:00 -0000 [thread overview]
Message-ID: <874kxwchi6.fsf@tromey.com> (raw)
In-Reply-To: <CAPTJ0XGMhMO=n6Fg9Z8-oHQBg60oftwnDWYELyEbGXitgpQR0A@mail.gmail.com> (Christian Biesinger via gdb-patches's message of "Wed, 18 Dec 2019 13:17:48 -0600")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> On Wed, Dec 18, 2019 at 10:35 AM Tom Tromey <tromey@adacore.com> wrote:
>> --- a/gdb/ui-out.h
>> +++ b/gdb/ui-out.h
>> @@ -77,8 +77,11 @@ enum ui_out_type
>> /* The possible kinds of fields. */
>> enum class field_kind
>> {
>> - SIGNED,
>> - STRING,
>> + /* "FIELD_STRING" needs has a funny name to avoid clashes with
Christian> Remove either "needs" or "has"?
Ugh, sorry. I'll fix it.
Christian> It is very unfortunate that a member of an enum class will need a
Christian> prefix, since the entire point of an enum class is not to need that :(
Yeah. I have a dream of not using bison at all, but that's a lot of
work for a pretty small benefit in the end.
Also sometimes I wonder if we want to continue using all caps for "enum
class" constants.
Tom
next prev parent reply other threads:[~2019-12-19 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 15:05 Tom Tromey
2019-12-18 16:21 ` Pedro Alves
2019-12-18 16:35 ` Tom Tromey
2019-12-18 16:38 ` Pedro Alves
2019-12-18 19:18 ` Christian Biesinger via gdb-patches
2019-12-19 18:11 ` Tom Tromey [this message]
2019-12-18 16:32 ` Simon Marchi
2019-12-18 16:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kxwchi6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox