From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99757 invoked by alias); 19 Dec 2019 18:11:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99748 invoked by uid 89); 19 Dec 2019 18:11:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=bison, SIGNED, clashes, field_string X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 18:11:50 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 060C62A307A for ; Thu, 19 Dec 2019 12:11:46 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i0H4iiYXkiJ43i0H4i6Smn; Thu, 19 Dec 2019 12:11:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZSXvKI7JybTPxAdawkqD/wrNVZQQx1PP3jP3K3QWGAs=; b=eT0Mxi7p2U7ckdeZiPxtyGVE5M KbaThA11GXhtRO3vLxglWOZGdoJCoXVJlGchCzy08t8UlGy2R7be07GsizX0dE2sYg1OqSTuDSI5s 4fVSWldmCW78aiKyf1TDlwD/v; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:37430 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ii0H4-0014SQ-2g; Thu, 19 Dec 2019 11:11:46 -0700 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Tom Tromey , Christian Biesinger , Pedro Alves Subject: Re: [PATCH] Fix build failure on macOS References: <20191218150518.8540-1-tromey@adacore.com> <69bd0545-37c4-9e4b-a3dd-7c7c4cf6e3e6@redhat.com> <87pngloala.fsf@tromey.com> Date: Thu, 19 Dec 2019 18:11:00 -0000 In-Reply-To: (Christian Biesinger via gdb-patches's message of "Wed, 18 Dec 2019 13:17:48 -0600") Message-ID: <874kxwchi6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00822.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> On Wed, Dec 18, 2019 at 10:35 AM Tom Tromey wrote: >> --- a/gdb/ui-out.h >> +++ b/gdb/ui-out.h >> @@ -77,8 +77,11 @@ enum ui_out_type >> /* The possible kinds of fields. */ >> enum class field_kind >> { >> - SIGNED, >> - STRING, >> + /* "FIELD_STRING" needs has a funny name to avoid clashes with Christian> Remove either "needs" or "has"? Ugh, sorry. I'll fix it. Christian> It is very unfortunate that a member of an enum class will need a Christian> prefix, since the entire point of an enum class is not to need that :( Yeah. I have a dream of not using bison at all, but that's a lot of work for a pretty small benefit in the end. Also sometimes I wonder if we want to continue using all caps for "enum class" constants. Tom