From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79954 invoked by alias); 18 Dec 2019 19:18:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79945 invoked by uid 89); 18 Dec 2019 19:18:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.3 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.210.68, H*RU:209.85.210.68, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 19:18:26 +0000 Received: by mail-ot1-f68.google.com with SMTP id 66so3751704otd.9 for ; Wed, 18 Dec 2019 11:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a/JzBrSDEh7FdLTaq6NAhjaNhwsiphq90lqZdgWEayY=; b=WaxLJBBlL11Hyev+tcrUVGDO+ki5xKaydwzdsMC57Np8EFTb7NXAUAOh/6lhdIifJ6 ygcjDwupFF4yk7O/dowsRyXwpbFg7L1tzz03n/nYXwTorIJWwpoxAvB+7CfckyWXmbQ0 INf22gpxTDieQyTRJdTG6/N2A/WgjhnZ6KAMF8Ilg2Pzm+kwctDUwMnUfRdYiqMTYzyq L/yw8LrEpcCrug4idl42MY0T0anyocSv59erIbSajgET0JGHhxnB9sh1aeouPaCevcCW yIBSrnNTg7R5MZKszrv5wHo24XSZ/6kaJi09yfLhsToKVAyhOROrVWClzEDHVZCLUM70 +W8Q== MIME-Version: 1.0 References: <20191218150518.8540-1-tromey@adacore.com> <69bd0545-37c4-9e4b-a3dd-7c7c4cf6e3e6@redhat.com> <87pngloala.fsf@tromey.com> In-Reply-To: <87pngloala.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 18 Dec 2019 19:18:00 -0000 Message-ID: Subject: Re: [PATCH] Fix build failure on macOS To: Tom Tromey Cc: Pedro Alves , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00790.txt.bz2 On Wed, Dec 18, 2019 at 10:35 AM Tom Tromey wrote: > --- a/gdb/ui-out.h > +++ b/gdb/ui-out.h > @@ -77,8 +77,11 @@ enum ui_out_type > /* The possible kinds of fields. */ > enum class field_kind > { > - SIGNED, > - STRING, > + /* "FIELD_STRING" needs has a funny name to avoid clashes with Remove either "needs" or "has"? It is very unfortunate that a member of an enum class will need a prefix, since the entire point of an enum class is not to need that :( Christian