From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 1/2] Change iterate_over_breakpoints to take a function_view
Date: Thu, 10 Oct 2019 00:13:00 -0000 [thread overview]
Message-ID: <CAPTJ0XG4ma9h=MuekFueh10dQT0ZwsePG94VoWqQqwm+vrDcBw@mail.gmail.com> (raw)
In-Reply-To: <87k19dbpkj.fsf@tromey.com>
On Wed, Oct 9, 2019 at 4:02 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> cbiesinger <cbiesinger@chromium.org> writes:
>
> > From: Christian Biesinger <cbiesinger@google.com>
> > This allows callers to pass in capturing lambdas. I have not changed the
> > signature to remove the void* argument or to change the return type to
> > bool; that can be done in a future cleanup.
>
> > gdb/ChangeLog:
>
> > 2019-10-09 Christian Biesinger <cbiesinger@google.com>
>
> > * breakpoint.c (iterate_over_breakpoints): Change function pointer to
> > a gdb::function_view.
> > * breakpoint.h (iterate_over_breakpoints): Likewise.
> > +iterate_over_breakpoints
> > + (gdb::function_view<int (breakpoint *, void *)> callback, void *data)
>
> I think normally a function_view conversion would remove the "void *"
> callback data, because that can be passed in via the closure now.
OK, sent that as v3 of this patchset.
Christian
prev parent reply other threads:[~2019-10-10 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 19:39 cbiesinger
2019-10-09 19:39 ` [PATCH v2 2/2] Make tui-winsource not use breakpoint_chain cbiesinger
2019-10-09 21:02 ` [PATCH v2 1/2] Change iterate_over_breakpoints to take a function_view Tom Tromey
2019-10-10 0:13 ` Christian Biesinger via gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XG4ma9h=MuekFueh10dQT0ZwsePG94VoWqQqwm+vrDcBw@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox