From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159437-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 84302 invoked by alias); 10 Oct 2019 00:13:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 84293 invoked by uid 89); 10 Oct 2019 00:13:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-17.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=
X-HELO: mail-ot1-f66.google.com
Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 00:13:43 +0000
Received: by mail-ot1-f66.google.com with SMTP id o44so3300747ota.10        for <gdb-patches@sourceware.org>; Wed, 09 Oct 2019 17:13:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=B6vdet/nJhXGSYlTydV7yoBCEaPGeZTaM1Az5J44HsE=;        b=kUmAb6z2OcajmI588Z30Xz0ifO0v3NTv548hR0+DvaQXcnaL5ZpMorcGr283gty/DV         MmL/CwBuKGcZtTcVNap4IVCr2j7rWuB/oTv+uOYYwcjE076aPehQgCZuo93ZwRhl7/K9         hPicBKf+suRodv3AihgkS7o42qzPjxDFTZAAH9XJPwzhEBbi58rCHMExyY5/IZk3Uxua         7hLEmWpPJRGmE55y0BV/KN/yjyBxM40287BHbNW4pPL3YxwR/sGqdv2S7G6jKYg9zbWo         jktTdXTaxp+Ga6ISykJRcvSn9DeYcD5xRjXeSrOIoP4Lsp52YOl/Qg2uUsjAQ732fv26         swSA==
MIME-Version: 1.0
References: <20191009193938.147076-1-cbiesinger@chromium.org> <87k19dbpkj.fsf@tromey.com>
In-Reply-To: <87k19dbpkj.fsf@tromey.com>
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Christian Biesinger <cbiesinger@google.com>
Date: Thu, 10 Oct 2019 00:13:00 -0000
Message-ID: <CAPTJ0XG4ma9h=MuekFueh10dQT0ZwsePG94VoWqQqwm+vrDcBw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] Change iterate_over_breakpoints to take a function_view
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-10/txt/msg00269.txt.bz2

On Wed, Oct 9, 2019 at 4:02 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> cbiesinger  <cbiesinger@chromium.org> writes:
>
> > From: Christian Biesinger <cbiesinger@google.com>
> > This allows callers to pass in capturing lambdas. I have not changed the
> > signature to remove the void* argument or to change the return type to
> > bool; that can be done in a future cleanup.
>
> > gdb/ChangeLog:
>
> > 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
>
> >       * breakpoint.c (iterate_over_breakpoints): Change function pointer to
> >       a gdb::function_view.
> >       * breakpoint.h (iterate_over_breakpoints): Likewise.
> > +iterate_over_breakpoints
> > +  (gdb::function_view<int (breakpoint *, void *)> callback, void *data)
>
> I think normally a function_view conversion would remove the "void *"
> callback data, because that can be passed in via the closure now.

OK, sent that as v3 of this patchset.

Christian