From: Tom Tromey <tom@tromey.com>
To: cbiesinger@chromium.org
Cc: gdb-patches@sourceware.org, Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH v2 1/2] Change iterate_over_breakpoints to take a function_view
Date: Wed, 09 Oct 2019 21:02:00 -0000 [thread overview]
Message-ID: <87k19dbpkj.fsf@tromey.com> (raw)
In-Reply-To: <20191009193938.147076-1-cbiesinger@chromium.org> (cbiesinger's message of "Wed, 9 Oct 2019 14:39:37 -0500")
>>>>> cbiesinger <cbiesinger@chromium.org> writes:
> From: Christian Biesinger <cbiesinger@google.com>
> This allows callers to pass in capturing lambdas. I have not changed the
> signature to remove the void* argument or to change the return type to
> bool; that can be done in a future cleanup.
> gdb/ChangeLog:
> 2019-10-09 Christian Biesinger <cbiesinger@google.com>
> * breakpoint.c (iterate_over_breakpoints): Change function pointer to
> a gdb::function_view.
> * breakpoint.h (iterate_over_breakpoints): Likewise.
> +iterate_over_breakpoints
> + (gdb::function_view<int (breakpoint *, void *)> callback, void *data)
I think normally a function_view conversion would remove the "void *"
callback data, because that can be passed in via the closure now.
Tom
next prev parent reply other threads:[~2019-10-09 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 19:39 cbiesinger
2019-10-09 19:39 ` [PATCH v2 2/2] Make tui-winsource not use breakpoint_chain cbiesinger
2019-10-09 21:02 ` Tom Tromey [this message]
2019-10-10 0:13 ` [PATCH v2 1/2] Change iterate_over_breakpoints to take a function_view Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k19dbpkj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@chromium.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox