From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71826 invoked by alias); 9 Oct 2019 21:02:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71413 invoked by uid 89); 9 Oct 2019 21:02:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=cbiesinger X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2019 21:02:08 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id B6E26FF946 for ; Wed, 9 Oct 2019 16:02:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IJ5ximuUT3Qi0IJ5xiK3Ic; Wed, 09 Oct 2019 16:02:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c/8KVvm/5+YaGesX+8nz4PHWumUQ1K1TtKDc29BLfJM=; b=UFN2R4VBtqkDD8CqRYgZ0OSqSY m1Z8lOqKNi86ZoiEjgIvjEDYID6VDTxTzkgPoZn3BH1SJRuVZKzKytbtv9iGN+HoRCuRMRMLu/90L E8HHv43VoelKHJqxEnqe+kig2; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:60114 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iIJ5x-003RhD-Lj; Wed, 09 Oct 2019 15:02:05 -0600 From: Tom Tromey To: cbiesinger@chromium.org Cc: gdb-patches@sourceware.org, Christian Biesinger Subject: Re: [PATCH v2 1/2] Change iterate_over_breakpoints to take a function_view References: <20191009193938.147076-1-cbiesinger@chromium.org> Date: Wed, 09 Oct 2019 21:02:00 -0000 In-Reply-To: <20191009193938.147076-1-cbiesinger@chromium.org> (cbiesinger's message of "Wed, 9 Oct 2019 14:39:37 -0500") Message-ID: <87k19dbpkj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00265.txt.bz2 >>>>> cbiesinger writes: > From: Christian Biesinger > This allows callers to pass in capturing lambdas. I have not changed the > signature to remove the void* argument or to change the return type to > bool; that can be done in a future cleanup. > gdb/ChangeLog: > 2019-10-09 Christian Biesinger > * breakpoint.c (iterate_over_breakpoints): Change function pointer to > a gdb::function_view. > * breakpoint.h (iterate_over_breakpoints): Likewise. > +iterate_over_breakpoints > + (gdb::function_view callback, void *data) I think normally a function_view conversion would remove the "void *" callback data, because that can be passed in via the closure now. Tom