Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christian Biesinger <cbiesinger@google.com>
To: gdb-patches <gdb-patches@sourceware.org>,
	Simon Marchi <simark@simark.ca>,
	 Thomas Schwinge <thomas@codesourcery.com>,
	thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCH] hurd: Add shared mig declarations
Date: Mon, 1 Jun 2020 11:33:52 -0500	[thread overview]
Message-ID: <CAPTJ0XFRVKTFmoavY7ogV5v2uDV-C+ha6_Zr9d+v787R=RX=hA@mail.gmail.com> (raw)
In-Reply-To: <20200530182318.hh3k7uuhvhfrqo5g@function>

On Sat, May 30, 2020 at 1:23 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Index: binutils-gdb/gdb/gnu-nat.c
> ===================================================================
> --- binutils-gdb.orig/gdb/gnu-nat.c
> +++ binutils-gdb/gdb/gnu-nat.c
> @@ -46,6 +46,9 @@ extern "C"
>  #include <hurd/sigpreempt.h>
>
>  #include <portinfo.h>
> +
> +/* MIG stubs are not yet ready for C++ compilation.  */
> +#include "gnu-nat-mig.h"
>  }

But since this is a header in GDB, why not just add that extern "C" to
make it ready for C++ compilation...?

Christian


      parent reply	other threads:[~2020-06-01 16:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30 18:23 Samuel Thibault
2020-05-30 18:30 ` Samuel Thibault
2020-05-30 19:51 ` Pedro Alves
2020-05-30 20:28   ` Samuel Thibault
2020-05-31  1:51 ` Simon Marchi
2020-05-31  7:20   ` Samuel Thibault
2020-06-01  2:05     ` Simon Marchi
2020-06-01  7:54       ` Samuel Thibault
2020-06-01 16:33 ` Christian Biesinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPTJ0XFRVKTFmoavY7ogV5v2uDV-C+ha6_Zr9d+v787R=RX=hA@mail.gmail.com' \
    --to=cbiesinger@google.com \
    --cc=bug-hurd@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=thomas@codesourcery.com \
    --cc=thomas@schwinge.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox