From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com
 [IPv6:2607:f8b0:4864:20::741])
 by sourceware.org (Postfix) with ESMTPS id D2CF73851C26
 for <gdb-patches@sourceware.org>; Mon,  1 Jun 2020 16:34:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2CF73851C26
Received: by mail-qk1-x741.google.com with SMTP id n141so9669633qke.2
 for <gdb-patches@sourceware.org>; Mon, 01 Jun 2020 09:34:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=8THuUwyR97dCMtcYTjGvcGrhHtZy9V1+EQo43HAxC64=;
 b=bw9pM0rYA0MY4vc9rXgamPiOUG80arwxEEs3d15iAs0Nm3hJTTOCENVZJn7elYwfXH
 77DwS7SDsI7UQNKolmijChsesQkfqBfnfcRbMQG/a6bM2dO/IxHeH0xeKpe65qawGBtN
 m6SXfuUbXZ3LrpHofQEUiW5+S3Y52B0eBuCXktH3QfPzXbmsRPBj2tx2xYa5mLEmu70M
 l38CWCFyE1flK0Zq45TFE4R8tCt/VBCV/MYOKeIATy9CrTN8Lm6MrvCUhaTYXNLIS5Vg
 D+1oRtuN17Wka1YUf1eSO7CqbB5+XB9lVcdsg5wP+sL6ODWpA2UFjlBDowS0cLeQb6Cy
 vJDg==
X-Gm-Message-State: AOAM531/0gqCQayKoZGKHcBy9dZWsQJy7jfaciYUWvTc852McLDxqauC
 I1KBXJ02ouarj8se5/jzPru5V8r07tFFlNEV/iyaBsDL
X-Google-Smtp-Source: ABdhPJyGyn1sFsYXphuFbR/Dt/kDqHV35pGIqVklb0h/QxTFO3frCHybwifzkkRfgzjKs1n3zZV1HltzF4cMN47IVk4=
X-Received: by 2002:a37:414f:: with SMTP id o76mr20037936qka.375.1591029268964; 
 Mon, 01 Jun 2020 09:34:28 -0700 (PDT)
MIME-Version: 1.0
References: <20200530182318.hh3k7uuhvhfrqo5g@function>
In-Reply-To: <20200530182318.hh3k7uuhvhfrqo5g@function>
From: Christian Biesinger <cbiesinger@google.com>
Date: Mon, 1 Jun 2020 11:33:52 -0500
Message-ID: <CAPTJ0XFRVKTFmoavY7ogV5v2uDV-C+ha6_Zr9d+v787R=RX=hA@mail.gmail.com>
Subject: Re: [PATCH] hurd: Add shared mig declarations
To: gdb-patches <gdb-patches@sourceware.org>, Simon Marchi <simark@simark.ca>, 
 Thomas Schwinge <thomas@codesourcery.com>, thomas@schwinge.name,
 bug-hurd@gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-18.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jun 2020 16:34:32 -0000

On Sat, May 30, 2020 at 1:23 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Index: binutils-gdb/gdb/gnu-nat.c
> ===================================================================
> --- binutils-gdb.orig/gdb/gnu-nat.c
> +++ binutils-gdb/gdb/gnu-nat.c
> @@ -46,6 +46,9 @@ extern "C"
>  #include <hurd/sigpreempt.h>
>
>  #include <portinfo.h>
> +
> +/* MIG stubs are not yet ready for C++ compilation.  */
> +#include "gnu-nat-mig.h"
>  }

But since this is a header in GDB, why not just add that extern "C" to
make it ready for C++ compilation...?

Christian