From: Christian Biesinger <cbiesinger@google.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Alexey Brodkin <alexey.brodkin@gmail.com>
Subject: Re: [PATCH] gdbsupport: include cstdlib in common-defs.h
Date: Fri, 10 Apr 2020 12:29:29 -0500 [thread overview]
Message-ID: <CAPTJ0XF-vn23eYZ2-SZq+_XRNKdhox6nECYXk4UvAv5FpD+6Cg@mail.gmail.com> (raw)
In-Reply-To: <877f2191-e491-f34a-1e39-993402f4e81f@polymtl.ca>
On Fri, Apr 10, 2020 at 9:40 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2020-04-09 7:34 p.m., Christian Biesinger wrote:
> > I think this is reasonable, but I would add a comment why both cstdlib
> > and stdlib.h are included (ie. to get the std:: version with
> > overloaded functions)
>
> A comment would certainly be useful. Does that sound right?
>
> /* Include both stdlib.h and cstdlib to make sure to get the standard C
> functions in the global namespace and the overloads in the std
> namespace. */
That sounds good to me.
next prev parent reply other threads:[~2020-04-10 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 22:50 Simon Marchi
2020-04-09 23:34 ` Christian Biesinger
2020-04-10 14:39 ` Simon Marchi
2020-04-10 17:29 ` Christian Biesinger [this message]
2020-04-27 13:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XF-vn23eYZ2-SZq+_XRNKdhox6nECYXk4UvAv5FpD+6Cg@mail.gmail.com \
--to=cbiesinger@google.com \
--cc=alexey.brodkin@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox