From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com
 [IPv6:2607:f8b0:4864:20::843])
 by sourceware.org (Postfix) with ESMTPS id 3AEF0385B835
 for <gdb-patches@sourceware.org>; Fri, 10 Apr 2020 17:30:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3AEF0385B835
Received: by mail-qt1-x843.google.com with SMTP id w29so1594153qtv.3
 for <gdb-patches@sourceware.org>; Fri, 10 Apr 2020 10:30:07 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=RKkUFgunQ5sslvWBKhOTUvefh85MoFXtt/3b0DVN9F8=;
 b=cOQYp0YIU7YZ0KIDBaZ+KYfjeOU9mSzkL7StEbqUwP+zZFA01lTmh60MLIuzWM6rBf
 hkXPZIqIevpZOFUCNlsiq4QrObj+mvWIgvvHgVbFOaZMZPXQnhpus4cwjqs02XHpFDAW
 i2DrfalSYjpWM3V1xSi+XY9nLT8A1INocBIhgCd5WQsIU+MJfWmDcC/mpEjhUAtLgjR1
 R1kmbJtf9FCIs12BjpRDY8pj1ftbYD7Wg+cG9WR1Y/4r7wixvWHEERP95BkHRuoaHi89
 lCWAStsovPQ1HJpm35Cls5h2pzDjJq8yRGCiCPvQWvxfVsTKN6YpL6dLp6tEOZ8rCCca
 WWPQ==
X-Gm-Message-State: AGi0Pub/qEIut03yTYQ9wWyEPyQmL5MIkK0kuBBILfex0ZEWn5Ed12bK
 r1EBor+T7EANofTv/EynOsXXGo2DR8Gi9wpx1odqWg==
X-Google-Smtp-Source: APiQypJxJBBwatKJExuMYkDgpHx1I6m5QyfLpzd/kuXqKqGmDtlJvQtvjWXuxyWnZmOvSis92nIHYgdaVEJAuA92koA=
X-Received: by 2002:aed:3225:: with SMTP id y34mr254269qtd.19.1586539806433;
 Fri, 10 Apr 2020 10:30:06 -0700 (PDT)
MIME-Version: 1.0
References: <20200409225022.3093099-1-simon.marchi@polymtl.ca>
 <CAPTJ0XGthsVqyGT9odusuc1jNZbrB+85M2beBpz2moJeEo6A6Q@mail.gmail.com>
 <877f2191-e491-f34a-1e39-993402f4e81f@polymtl.ca>
In-Reply-To: <877f2191-e491-f34a-1e39-993402f4e81f@polymtl.ca>
From: Christian Biesinger <cbiesinger@google.com>
Date: Fri, 10 Apr 2020 12:29:29 -0500
Message-ID: <CAPTJ0XF-vn23eYZ2-SZq+_XRNKdhox6nECYXk4UvAv5FpD+6Cg@mail.gmail.com>
Subject: Re: [PATCH] gdbsupport: include cstdlib in common-defs.h
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches <gdb-patches@sourceware.org>,
 Alexey Brodkin <alexey.brodkin@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-22.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Apr 2020 17:30:08 -0000

On Fri, Apr 10, 2020 at 9:40 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2020-04-09 7:34 p.m., Christian Biesinger wrote:
> > I think this is reasonable, but I would add a comment why both cstdlib
> > and stdlib.h are included (ie. to get the std:: version with
> > overloaded functions)
>
> A comment would certainly be useful.  Does that sound right?
>
> /* Include both stdlib.h and cstdlib to make sure to get the standard C
>    functions in the global namespace and the overloads in the std
>    namespace.  */

That sounds good to me.