From: Simon Marchi <simon.marchi@polymtl.ca>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Alexey Brodkin <alexey.brodkin@gmail.com>
Subject: Re: [PATCH] gdbsupport: include cstdlib in common-defs.h
Date: Mon, 27 Apr 2020 09:30:00 -0400 [thread overview]
Message-ID: <9e6a9453-5855-b01d-99e4-10cb54c49e47@polymtl.ca> (raw)
In-Reply-To: <CAPTJ0XF-vn23eYZ2-SZq+_XRNKdhox6nECYXk4UvAv5FpD+6Cg@mail.gmail.com>
On 2020-04-10 1:29 p.m., Christian Biesinger wrote:
> On Fri, Apr 10, 2020 at 9:40 AM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> On 2020-04-09 7:34 p.m., Christian Biesinger wrote:
>>> I think this is reasonable, but I would add a comment why both cstdlib
>>> and stdlib.h are included (ie. to get the std:: version with
>>> overloaded functions)
>>
>> A comment would certainly be useful. Does that sound right?
>>
>> /* Include both stdlib.h and cstdlib to make sure to get the standard C
>> functions in the global namespace and the overloads in the std
>> namespace. */
>
> That sounds good to me.
>
I pushed this patch, although with a slightly different comment, because I forgot
I had written one here. But it says essentially the same thing.
Simon
prev parent reply other threads:[~2020-04-27 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 22:50 Simon Marchi
2020-04-09 23:34 ` Christian Biesinger
2020-04-10 14:39 ` Simon Marchi
2020-04-10 17:29 ` Christian Biesinger
2020-04-27 13:30 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e6a9453-5855-b01d-99e4-10cb54c49e47@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=alexey.brodkin@gmail.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox