From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E255D3870861 for ; Mon, 27 Apr 2020 13:30:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E255D3870861 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 03RDU32O012038 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Apr 2020 09:30:07 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 03RDU32O012038 Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A735C1E5F9; Mon, 27 Apr 2020 09:30:01 -0400 (EDT) Subject: Re: [PATCH] gdbsupport: include cstdlib in common-defs.h To: Christian Biesinger Cc: gdb-patches , Alexey Brodkin References: <20200409225022.3093099-1-simon.marchi@polymtl.ca> <877f2191-e491-f34a-1e39-993402f4e81f@polymtl.ca> From: Simon Marchi Message-ID: <9e6a9453-5855-b01d-99e4-10cb54c49e47@polymtl.ca> Date: Mon, 27 Apr 2020 09:30:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 27 Apr 2020 13:30:03 +0000 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 13:30:25 -0000 On 2020-04-10 1:29 p.m., Christian Biesinger wrote: > On Fri, Apr 10, 2020 at 9:40 AM Simon Marchi wrote: >> >> On 2020-04-09 7:34 p.m., Christian Biesinger wrote: >>> I think this is reasonable, but I would add a comment why both cstdlib >>> and stdlib.h are included (ie. to get the std:: version with >>> overloaded functions) >> >> A comment would certainly be useful. Does that sound right? >> >> /* Include both stdlib.h and cstdlib to make sure to get the standard C >> functions in the global namespace and the overloads in the std >> namespace. */ > > That sounds good to me. > I pushed this patch, although with a slightly different comment, because I forgot I had written one here. But it says essentially the same thing. Simon