From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Move arm_apcs_32 extern declaration to header
Date: Fri, 20 Sep 2019 00:19:00 -0000 [thread overview]
Message-ID: <CAPTJ0XEy2jBw+Bqhpk15m2sK6gvE99diqVYEpPcwgNw7szr8RQ@mail.gmail.com> (raw)
In-Reply-To: <5b3baa25-23aa-b2b3-ef4d-ab882d316582@simark.ca>
On Thu, Sep 19, 2019 at 8:04 PM Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-09-19 12:35 a.m., Christian Biesinger via gdb-patches wrote:
> > Instead of having several extern declarations for arm_apcs_32
> > in a few .c files, declare it in arm-tdep.h. This file is already
> > included from these .c files.
>
> LGTM. If you want, you can also move the documentation of the variable
> to the .h and use /* See arm-tdep.h. */ in the .c.
Thanks, made that change and pushed.
To ssh://sourceware.org/git/binutils-gdb.git
e86f08d28f4..c7ae7675cf7 HEAD -> master
Christian
prev parent reply other threads:[~2019-09-20 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 4:35 Christian Biesinger via gdb-patches
2019-09-19 11:04 ` Simon Marchi
2019-09-20 0:19 ` Christian Biesinger via gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPTJ0XEy2jBw+Bqhpk15m2sK6gvE99diqVYEpPcwgNw7szr8RQ@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox