From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30529 invoked by alias); 20 Sep 2019 00:19:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30521 invoked by uid 89); 20 Sep 2019 00:19:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.8 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_JMF_BL,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=no version=3.3.1 spammy= X-HELO: mail-oi1-f193.google.com Received: from mail-oi1-f193.google.com (HELO mail-oi1-f193.google.com) (209.85.167.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2019 00:19:21 +0000 Received: by mail-oi1-f193.google.com with SMTP id k20so309356oih.3 for ; Thu, 19 Sep 2019 17:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dFrV4TN1eHP/iCNfQFvIVf2+pcQqReoICKI8ZlF5x6U=; b=Ybsxk9vCHeqTEdeBp5ac3Mh8r91HdFioziNh5gMcJEBkssCxAHzZ//nxrN5d7/zhIj 5sJydN6IGH/r78HjExSOHv9ZKs5phcAt4FxTXfyi6+Rulz364ZsONyyE8dacmOVsI9DB A+8sS+x/rbtFL6tm3FWDEq9lj2OViH9pYpAH3Mzl0hbZJ5Neu0ZjtSlQeD0zj2XkHQtY ANEySAWaNkNcAr0r1Hfvv5Q6ooMyEj7MKri3veHpZlni6mHcO/NOi+Booy3TIPkewNka Utn9g4pXo6uRELqTaNjbDn8p8AeS3Ma9L7ja+N483jkJnkGra4Zd/LBytADkWnNmqvMh V/UQ== MIME-Version: 1.0 References: <20190919043533.45876-1-cbiesinger@google.com> <5b3baa25-23aa-b2b3-ef4d-ab882d316582@simark.ca> In-Reply-To: <5b3baa25-23aa-b2b3-ef4d-ab882d316582@simark.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 20 Sep 2019 00:19:00 -0000 Message-ID: Subject: Re: [PATCH] Move arm_apcs_32 extern declaration to header To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00386.txt.bz2 On Thu, Sep 19, 2019 at 8:04 PM Simon Marchi wrote: > > On 2019-09-19 12:35 a.m., Christian Biesinger via gdb-patches wrote: > > Instead of having several extern declarations for arm_apcs_32 > > in a few .c files, declare it in arm-tdep.h. This file is already > > included from these .c files. > > LGTM. If you want, you can also move the documentation of the variable > to the .h and use /* See arm-tdep.h. */ in the .c. Thanks, made that change and pushed. To ssh://sourceware.org/git/binutils-gdb.git e86f08d28f4..c7ae7675cf7 HEAD -> master Christian