From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [PATCH] Move arm_apcs_32 extern declaration to header
Date: Thu, 19 Sep 2019 04:35:00 -0000 [thread overview]
Message-ID: <20190919043533.45876-1-cbiesinger@google.com> (raw)
Instead of having several extern declarations for arm_apcs_32
in a few .c files, declare it in arm-tdep.h. This file is already
included from these .c files.
gdb/ChangeLog:
2019-09-19 Christian Biesinger <cbiesinger@google.com>
* arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
* arm-linux-tdep.c: Likewise.
* arm-nbsd-nat.c: Likewise.
* arm-tdep.h: Declare arm_apcs_32.
---
gdb/arm-linux-nat.c | 2 --
gdb/arm-linux-tdep.c | 1 -
gdb/arm-nbsd-nat.c | 2 --
gdb/arm-tdep.h | 2 ++
4 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index ef44e68d319..bef67c7ac7d 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -66,8 +66,6 @@
#define PTRACE_SETHBPREGS 30
#endif
-extern bool arm_apcs_32;
-
class arm_linux_nat_target final : public linux_nat_target
{
public:
diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c
index 31ea4564dbb..54ea8511cba 100644
--- a/gdb/arm-linux-tdep.c
+++ b/gdb/arm-linux-tdep.c
@@ -56,7 +56,6 @@
#include "user-regs.h"
#include <ctype.h>
#include "elf/common.h"
-extern bool arm_apcs_32;
/* Under ARM GNU/Linux the traditional way of performing a breakpoint
is to execute a particular software interrupt, rather than use a
diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
index 38a9e954b92..5160bfddf50 100644
--- a/gdb/arm-nbsd-nat.c
+++ b/gdb/arm-nbsd-nat.c
@@ -40,8 +40,6 @@ public:
static arm_netbsd_nat_target the_arm_netbsd_nat_target;
-extern bool arm_apcs_32;
-
static void
arm_supply_gregset (struct regcache *regcache, struct reg *gregset)
{
diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h
index 6d1a91ca35e..e9590e16bab 100644
--- a/gdb/arm-tdep.h
+++ b/gdb/arm-tdep.h
@@ -26,6 +26,8 @@ struct get_next_pcs;
struct arm_get_next_pcs;
struct gdb_get_next_pcs;
+extern bool arm_apcs_32;
+
#include "gdbarch.h"
#include "arch/arm.h"
#include "infrun.h"
--
2.23.0.351.gc4317032e6-goog
next reply other threads:[~2019-09-19 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 4:35 Christian Biesinger via gdb-patches [this message]
2019-09-19 11:04 ` Simon Marchi
2019-09-20 0:19 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919043533.45876-1-cbiesinger@google.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox