Re: [PATCH/committed] sim: rx: cast bfd_vma when printing

[Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org>]

On Sat, May 1, 2021, 15:29 Mike Frysinger via Gdb-patches <
gdb-patches@sourceware.org> wrote:

> A bit of a hack, but it's what we've been doing so far when printing
> bfd_vma's since bfd doesn't provide PRI helper types for us to use.
> ---
>  sim/rx/ChangeLog | 4 ++++
>  sim/rx/load.c    | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/sim/rx/ChangeLog b/sim/rx/ChangeLog
> index 7541c9d7141b..633ed86780c7 100644
> --- a/sim/rx/ChangeLog
> +++ b/sim/rx/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-05-01  Mike Frysinger  <vapier@gentoo.org>
> +
> +       * load.c (rx_load): Cast size to long.
> +
>  2021-04-26  Mike Frysinger  <vapier@gentoo.org>
>
>         * Makefile.in (NL_TARGET): Delete.
> diff --git a/sim/rx/load.c b/sim/rx/load.c
> index a8a473346c67..b4523e12ac75 100644
> --- a/sim/rx/load.c
> +++ b/sim/rx/load.c
> @@ -151,7 +151,7 @@ rx_load (bfd *prog, host_callback *callback)
>         }
>        if (bfd_bread (buf, size, prog) != size)
>         {
> -         fprintf (stderr, "Failed to read %lx bytes\n", size);
> +         fprintf (stderr, "Failed to read %lx bytes\n", (long) size);
>

Wouldn't it be better to use "long long", especially for mingw?

Christian

          continue;
>         }
>
> --
> 2.31.1
>
>