From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HNGQBIRGkGBwSQAAWB0awg (envelope-from ) for ; Mon, 03 May 2021 14:52:52 -0400 Received: by simark.ca (Postfix, from userid 112) id 0AA551F11C; Mon, 3 May 2021 14:52:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EF7291E01F for ; Mon, 3 May 2021 14:52:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 67362393C846; Mon, 3 May 2021 18:52:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67362393C846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620067970; bh=OU9Ck4jzbRuTa4e76LnScl6rXghVlg2HYCp3hW1axGk=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rwxmKOhy8zyS3Tzjp2dnFm2DGMGYZi75u8sJnO7HDdMow8H6H6LJGfAW4B97gm5Hv eje9VbiT9rA8ewIQPoY9O8vaES+xp+vslT5GMn0KI+qmcdfx4kcEF4YbPkNEevfN/T Z00oO45w/jy9OWC/BSX4tYfB3AF5xbFmRxBzwcIw= Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id BD32D393BC2F for ; Mon, 3 May 2021 18:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD32D393BC2F Received: by mail-qk1-x72d.google.com with SMTP id q127so6154577qkb.1 for ; Mon, 03 May 2021 11:52:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nBLlKkOzB8Wcns5oL7LRgfRxZ2ZZ2gSLduKcZQVBxxU=; b=i1xuXjM9mFPeNrPpfo4ql4y6GAL9lY7rr5KQsuYVHsR4Wdc4SQ3HmWwmXLFZFT82sv y5dIkUuLGVvAr4T+edQIHi1Zt7cOIgE2YuI/XEQ8ASm5BBzT7Bkz376Op0ogTrd84i+U iPMJxDPVl2i8ox9+AIB/xZXcSbDGbpKSnnyblAGk6wbmA+Qc+ffsBwwM0vs6G0lDnuUC 2K/TE4BndcwQbXHAH6vvY2k87v/hRQ7WbJEPclKZFNeZrMlOAlgNdLQBy12dJK8j6i1B yLuzaVeV8LSBEk62QFAWJg7Fu6/+EOImUcpBcGW+akRnIH4V4+gknBOIl1uK8IXg+wkM +9+g== X-Gm-Message-State: AOAM533kgruA1C/fahqVSwM3u17H0fZkCO4BrepRM8Irkg0fbftX1+gM 1271FH5fZxThlp2tbmy2KbhComkRyPcu+MHBSxwNlw1071o= X-Google-Smtp-Source: ABdhPJxAg5YvAAwkM16nRO7ejBPvTciK/cIWLkhjMwiusCYu63nE5rh2WjAEVXuUVYguGVCb1KZHgxZqpl6sS+xkQho= X-Received: by 2002:a37:658a:: with SMTP id z132mr21078168qkb.28.1620067967134; Mon, 03 May 2021 11:52:47 -0700 (PDT) MIME-Version: 1.0 References: <20210501202929.29766-1-vapier@gentoo.org> In-Reply-To: <20210501202929.29766-1-vapier@gentoo.org> Date: Mon, 3 May 2021 11:20:56 -0500 Message-ID: Subject: Re: [PATCH/committed] sim: rx: cast bfd_vma when printing To: Mike Frysinger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sat, May 1, 2021, 15:29 Mike Frysinger via Gdb-patches < gdb-patches@sourceware.org> wrote: > A bit of a hack, but it's what we've been doing so far when printing > bfd_vma's since bfd doesn't provide PRI helper types for us to use. > --- > sim/rx/ChangeLog | 4 ++++ > sim/rx/load.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/sim/rx/ChangeLog b/sim/rx/ChangeLog > index 7541c9d7141b..633ed86780c7 100644 > --- a/sim/rx/ChangeLog > +++ b/sim/rx/ChangeLog > @@ -1,3 +1,7 @@ > +2021-05-01 Mike Frysinger > + > + * load.c (rx_load): Cast size to long. > + > 2021-04-26 Mike Frysinger > > * Makefile.in (NL_TARGET): Delete. > diff --git a/sim/rx/load.c b/sim/rx/load.c > index a8a473346c67..b4523e12ac75 100644 > --- a/sim/rx/load.c > +++ b/sim/rx/load.c > @@ -151,7 +151,7 @@ rx_load (bfd *prog, host_callback *callback) > } > if (bfd_bread (buf, size, prog) != size) > { > - fprintf (stderr, "Failed to read %lx bytes\n", size); > + fprintf (stderr, "Failed to read %lx bytes\n", (long) size); > Wouldn't it be better to use "long long", especially for mingw? Christian continue; > } > > -- > 2.31.1 > >