Re: [PATCH/committed] sim: rx: cast bfd_vma when printing

[Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org>]

On Mon, May 3, 2021 at 3:57 PM Mike Frysinger <vapier@gentoo.org> wrote:
>
> On 03 May 2021 11:20, Christian Biesinger wrote:
> > On Sat, May 1, 2021, 15:29 Mike Frysinger wrote:
> > > A bit of a hack, but it's what we've been doing so far when printing
> > > bfd_vma's since bfd doesn't provide PRI helper types for us to use.
> > >
> > > --- a/sim/rx/load.c
> > > +++ b/sim/rx/load.c
> > > @@ -151,7 +151,7 @@ rx_load (bfd *prog, host_callback *callback)
> > >         }
> > >        if (bfd_bread (buf, size, prog) != size)
> > >         {
> > > -         fprintf (stderr, "Failed to read %lx bytes\n", size);
> > > +         fprintf (stderr, "Failed to read %lx bytes\n", (long) size);
> >
> > Wouldn't it be better to use "long long", especially for mingw?
>
> not sure why mingw is special here.  but let's ignore that.

mingw (and msvc) is special because sizeof(long) is 4, even on a 64-bit system.
https://stackoverflow.com/questions/22344388/size-of-long-int-and-int-in-c-showing-4-bytes

> bfd_vma printing is poorly handled in many places in sim when bfd_vma is 64-bit
> but the host cpu is 32-bit (i.e. sizeof(long) == 4).  the (long) cast pattern
> that i used here for printing is based on those.  i don't think sim is the only
> place that does this poorly tbh, it's just what i'm focusing on.

But if other places already do that, then eh...

Christian