Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: Pierre-Marie de Rodat <derodat@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Replace the block_found global with explicit data-flow
Date: Wed, 22 Jul 2015 14:15:00 -0000	[thread overview]
Message-ID: <CAP9bCMTvYtudswiBGHMdygr4uN+U1ztdMd-ydhjdb7NWXbMzsA@mail.gmail.com> (raw)
In-Reply-To: <55AE943F.3000009@adacore.com>

On Tue, Jul 21, 2015 at 11:49 AM, Pierre-Marie de Rodat
<derodat@adacore.com> wrote:
> On 07/21/2015 06:36 PM, Pierre-Marie de Rodat wrote:
>>
>> As Pedro suggested on gdb-patches@ (see
>> <https://sourceware.org/ml/gdb-patches/2015-05/msg00714.html>), this
>> change makes symbol lookup functions return a structure that includes
>> both the symbol found and the block in which it was found.  This makes
>> it possible to get rid of the block_found global variable and thus makes
>> block hunting explicit.
>>
>> I saw no regression on x86_64-linux. Ok for trunk?
>
>
> Ahem… here’s the patch… :-/ One day I will take some time to configure git
> send-email...

Hi.

Thanks.  Others may approve this, but as I've had my hand in all of this code
more than anyone recently I'd like  to review it too.
I'll have time this weekend, fingers crossed.


  reply	other threads:[~2015-07-22 14:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21 16:37 Pierre-Marie de Rodat
2015-07-21 18:49 ` Pierre-Marie de Rodat
2015-07-22 14:15   ` Doug Evans [this message]
2015-07-22 15:07     ` Pierre-Marie de Rodat
2015-07-22 15:48     ` Iain Buclaw
2015-07-30 13:44       ` Pierre-Marie de Rodat
2015-07-25 21:24   ` Doug Evans
2015-07-30 13:42     ` Pierre-Marie de Rodat
2015-08-01  8:57       ` Pierre-Marie de Rodat
2015-08-01  9:09         ` Pierre-Marie de Rodat
2015-08-01  9:35           ` Pierre-Marie de Rodat
2015-08-01 16:04             ` Luis Machado
2015-08-01 16:25               ` Pierre-Marie de Rodat
2015-08-01 18:24                 ` Luis Machado
2015-08-01 19:36                   ` Pierre-Marie de Rodat
2015-08-01 23:19                     ` Luis Machado
2015-08-02 18:17             ` Pedro Alves
2015-08-03  7:44               ` Pierre-Marie de Rodat
2015-08-03 16:39           ` Steve Ellcey
2015-08-03 17:12             ` Ulrich Weigand
2015-08-04  8:13               ` Pierre-Marie de Rodat
2015-08-03 17:12             ` Pedro Alves
2015-08-02 17:42         ` Doug Evans
2015-08-03  7:43           ` Pierre-Marie de Rodat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP9bCMTvYtudswiBGHMdygr4uN+U1ztdMd-ydhjdb7NWXbMzsA@mail.gmail.com \
    --to=xdje42@gmail.com \
    --cc=derodat@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox