Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pierre-Marie de Rodat <derodat@adacore.com>
To: Luis Machado <lgustavo@codesourcery.com>,  Doug Evans <xdje42@gmail.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	 Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Replace the block_found global with explicit data-flow
Date: Sat, 01 Aug 2015 19:36:00 -0000	[thread overview]
Message-ID: <55BD1F9E.6000603@adacore.com> (raw)
In-Reply-To: <55BD0EDD.9040903@codesourcery.com>

On 08/01/2015 08:24 PM, Luis Machado wrote:
>> Understood: here's an updated patch introducing a temporary to do this.
>> Thank you!
>
> Thanks!
>
> I think you forgot to fix the other occurrences though.

Arg, sorry: I thought you were suggesting this to get rid of the weird 
indentation behavior (hence my fix on the first occurence only).

At this point I wonder what to do: this patch indeed introduces some of 
“foo(..).bar” constructs, but my previous one introduced a _lot_ more. 
So my feeling is that the code will get bigger and less readable... 
that's my personal taste anyway. ;-) That being said, I'm completely 
open to settling on this style anyway, as long as we are aware of the 
consequences.

-- 
Pierre-Marie de Rodat


  reply	other threads:[~2015-08-01 19:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21 16:37 Pierre-Marie de Rodat
2015-07-21 18:49 ` Pierre-Marie de Rodat
2015-07-22 14:15   ` Doug Evans
2015-07-22 15:07     ` Pierre-Marie de Rodat
2015-07-22 15:48     ` Iain Buclaw
2015-07-30 13:44       ` Pierre-Marie de Rodat
2015-07-25 21:24   ` Doug Evans
2015-07-30 13:42     ` Pierre-Marie de Rodat
2015-08-01  8:57       ` Pierre-Marie de Rodat
2015-08-01  9:09         ` Pierre-Marie de Rodat
2015-08-01  9:35           ` Pierre-Marie de Rodat
2015-08-01 16:04             ` Luis Machado
2015-08-01 16:25               ` Pierre-Marie de Rodat
2015-08-01 18:24                 ` Luis Machado
2015-08-01 19:36                   ` Pierre-Marie de Rodat [this message]
2015-08-01 23:19                     ` Luis Machado
2015-08-02 18:17             ` Pedro Alves
2015-08-03  7:44               ` Pierre-Marie de Rodat
2015-08-03 16:39           ` Steve Ellcey
2015-08-03 17:12             ` Pedro Alves
2015-08-03 17:12             ` Ulrich Weigand
2015-08-04  8:13               ` Pierre-Marie de Rodat
2015-08-02 17:42         ` Doug Evans
2015-08-03  7:43           ` Pierre-Marie de Rodat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BD1F9E.6000603@adacore.com \
    --to=derodat@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=palves@redhat.com \
    --cc=xdje42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox