From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28521 invoked by alias); 1 Aug 2015 19:36:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28508 invoked by uid 89); 1 Aug 2015 19:36:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 01 Aug 2015 19:36:02 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 4E2EB28B5133; Sat, 1 Aug 2015 21:35:59 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dLjlhGLflRxV; Sat, 1 Aug 2015 21:35:59 +0200 (CEST) Received: from [192.168.0.6] (nat75-2-78-193-84-173.fbxo.proxad.net [78.193.84.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id D662428B5131; Sat, 1 Aug 2015 21:35:58 +0200 (CEST) Message-ID: <55BD1F9E.6000603@adacore.com> Date: Sat, 01 Aug 2015 19:36:00 -0000 From: Pierre-Marie de Rodat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Luis Machado , Doug Evans CC: GDB Patches , Pedro Alves Subject: Re: [PATCH] Replace the block_found global with explicit data-flow References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> <55BA299D.7040407@adacore.com> <55BC89E6.9040705@adacore.com> <55BC8CA9.3070505@adacore.com> <55BC92D8.8070407@adacore.com> <55BCEDF1.2070806@codesourcery.com> <55BCF2E7.9000800@adacore.com> <55BD0EDD.9040903@codesourcery.com> In-Reply-To: <55BD0EDD.9040903@codesourcery.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00006.txt.bz2 On 08/01/2015 08:24 PM, Luis Machado wrote: >> Understood: here's an updated patch introducing a temporary to do this. >> Thank you! > > Thanks! > > I think you forgot to fix the other occurrences though. Arg, sorry: I thought you were suggesting this to get rid of the weird indentation behavior (hence my fix on the first occurence only). At this point I wonder what to do: this patch indeed introduces some of “foo(..).bar” constructs, but my previous one introduced a _lot_ more. So my feeling is that the code will get bigger and less readable... that's my personal taste anyway. ;-) That being said, I'm completely open to settling on this style anyway, as long as we are aware of the consequences. -- Pierre-Marie de Rodat