From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52229 invoked by alias); 22 Jul 2015 14:15:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52217 invoked by uid 89); 22 Jul 2015 14:15:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f170.google.com Received: from mail-yk0-f170.google.com (HELO mail-yk0-f170.google.com) (209.85.160.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 22 Jul 2015 14:15:16 +0000 Received: by ykay190 with SMTP id y190so193334983yka.3 for ; Wed, 22 Jul 2015 07:15:14 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.170.143.213 with SMTP id k204mr2603222ykc.91.1437574513998; Wed, 22 Jul 2015 07:15:13 -0700 (PDT) Received: by 10.13.233.198 with HTTP; Wed, 22 Jul 2015 07:15:13 -0700 (PDT) In-Reply-To: <55AE943F.3000009@adacore.com> References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> Date: Wed, 22 Jul 2015 14:15:00 -0000 Message-ID: Subject: Re: [PATCH] Replace the block_found global with explicit data-flow From: Doug Evans To: Pierre-Marie de Rodat Cc: GDB Patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00611.txt.bz2 On Tue, Jul 21, 2015 at 11:49 AM, Pierre-Marie de Rodat wrote: > On 07/21/2015 06:36 PM, Pierre-Marie de Rodat wrote: >> >> As Pedro suggested on gdb-patches@ (see >> ), this >> change makes symbol lookup functions return a structure that includes >> both the symbol found and the block in which it was found. This makes >> it possible to get rid of the block_found global variable and thus makes >> block hunting explicit. >> >> I saw no regression on x86_64-linux. Ok for trunk? > > > Ahem=E2=80=A6 here=E2=80=99s the patch=E2=80=A6 :-/ One day I will take s= ome time to configure git > send-email... Hi. Thanks. Others may approve this, but as I've had my hand in all of this co= de more than anyone recently I'd like to review it too. I'll have time this weekend, fingers crossed.