From: Doug Evans <xdje42@gmail.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/5] Remove struct main_type.vptr_{fieldno,basetype}: TYPE_SPECIFIC_SELF_TYPE
Date: Wed, 11 Feb 2015 06:28:00 -0000 [thread overview]
Message-ID: <CAP9bCMRW_LoR6dJB1iYs_1GwJx5p9UXK1qifmtXWcvP8SLACPg@mail.gmail.com> (raw)
In-Reply-To: <54d7775a.2b2c460a.5b38.7725SMTPIN_ADDED_BROKEN@mx.google.com>
On Sun, Feb 8, 2015 at 6:48 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
>> Here's a patch.
>> You're patch is on the right track, TYPE_SPECIFIC_FIELD can
>> legitimately be TYPE_SPECIFIC_NONE if the field hasn't been initialized
>> yet. I like the patch below as it's more general.
>
> I agree with you that this patch seems
> much secure, as it allows to use TYPE_SELF_TYPE as
> a test as before.
>
>
>> 2015-02-07 Doug Evans <xdje42@gmail.com>
>>
>> * gdbtypes.c (internal_type_self_type): If TYPE_SPECIFIC_FIELD
>> hasn't
>> been initialized yet, return NULL.
Committed.
prev parent reply other threads:[~2015-02-11 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 7:29 Doug Evans
2015-02-05 17:37 ` Pierre Muller
[not found] ` <54d3aa46.0660b40a.14f0.ffffeae7SMTPIN_ADDED_BROKEN@mx.google.com>
2015-02-06 7:21 ` Doug Evans
2015-02-07 17:47 ` Pierre Muller
[not found] ` <54d3aa6b.a23d460a.0d37.0908SMTPIN_ADDED_BROKEN@mx.google.com>
2015-02-07 23:06 ` Doug Evans
2015-02-08 14:48 ` Pierre Muller
[not found] ` <54d7775a.2b2c460a.5b38.7725SMTPIN_ADDED_BROKEN@mx.google.com>
2015-02-11 6:28 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9bCMRW_LoR6dJB1iYs_1GwJx5p9UXK1qifmtXWcvP8SLACPg@mail.gmail.com \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox