From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119777-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18244 invoked by alias); 11 Feb 2015 06:28:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18231 invoked by uid 89); 11 Feb 2015 06:28:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-we0-f178.google.com
Received: from mail-we0-f178.google.com (HELO mail-we0-f178.google.com) (74.125.82.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Feb 2015 06:28:43 +0000
Received: by mail-we0-f178.google.com with SMTP id w62so1317517wes.9        for <gdb-patches@sourceware.org>; Tue, 10 Feb 2015 22:28:40 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.180.97.67 with SMTP id dy3mr2428917wib.65.1423636120457; Tue, 10 Feb 2015 22:28:40 -0800 (PST)
Received: by 10.27.20.5 with HTTP; Tue, 10 Feb 2015 22:28:40 -0800 (PST)
In-Reply-To: <54d7775a.2b2c460a.5b38.7725SMTPIN_ADDED_BROKEN@mx.google.com>
References: <m3twze8kxc.fsf@sspiff.org>	<54d3aa6b.a23d460a.0d37.0908SMTPIN_ADDED_BROKEN@mx.google.com>	<m3iofdjpav.fsf@sspiff.org>	<54d7775a.2b2c460a.5b38.7725SMTPIN_ADDED_BROKEN@mx.google.com>
Date: Wed, 11 Feb 2015 06:28:00 -0000
Message-ID: <CAP9bCMRW_LoR6dJB1iYs_1GwJx5p9UXK1qifmtXWcvP8SLACPg@mail.gmail.com>
Subject: Re: [PATCH 4/5] Remove struct main_type.vptr_{fieldno,basetype}: TYPE_SPECIFIC_SELF_TYPE
From: Doug Evans <xdje42@gmail.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-02/txt/msg00290.txt.bz2

On Sun, Feb 8, 2015 at 6:48 AM, Pierre Muller
<pierre.muller@ics-cnrs.unistra.fr> wrote:
>> Here's a patch.
>> You're patch is on the right track, TYPE_SPECIFIC_FIELD can
>> legitimately be TYPE_SPECIFIC_NONE if the field hasn't been initialized
>> yet. I like the patch below as it's more general.
>
>   I agree with you that this patch seems
> much secure, as it allows to use TYPE_SELF_TYPE as
> a test as before.
>
>
>> 2015-02-07  Doug Evans  <xdje42@gmail.com>
>>
>>       * gdbtypes.c (internal_type_self_type): If TYPE_SPECIFIC_FIELD
>> hasn't
>>       been initialized yet, return NULL.

Committed.