Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.

[Doug Evans <xdje42@gmail.com>]

On Sat, Feb 7, 2015 at 4:02 PM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
> On 2/8/15 07:22, Doug Evans wrote:
>> On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>>> The related warnings:
>>>
>>>   gcc -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1          -DDEFAULT_INLINE=0              -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes  -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c
>>> ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’:
>>> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration]
>>>          cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]);
>>>                         ^
>>>   ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration]
>>>          cpu.gr[RET1] = access ((char *) a[0], a[1]);
>>>                         ^
>>>
>>> 2015-02-07  Chen Gang <gang.chen.5i5j@gmail.com>
>>>
>>>         * mcore/interp.c: Include "unistd.h" standard C header file to
>>>         avoid compiling warnings.
>>
>> LGTM
>
> Excuse me, I am not quite familiar with the short word, I guess it is "
> Look Good To ME",
>
> Is what I guess correct?

Looks Good To Me,
yeah