Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Doug Evans <xdje42@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
Date: Sat, 07 Feb 2015 23:54:00 -0000	[thread overview]
Message-ID: <54D6A794.7080107@sunrus.com.cn> (raw)
In-Reply-To: <CAP9bCMT1=7ufFF0hBuTre8VJSMOJBxMHKk77V7+wkymKd9fQVw@mail.gmail.com>

On 2/8/15 07:22, Doug Evans wrote:
> On Sat, Feb 7, 2015 at 6:19 AM, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>> The related warnings:
>>
>>   gcc -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1          -DDEFAULT_INLINE=0              -I. -I../../../binutils-gdb/sim/mcore -I../common -I../../../binutils-gdb/sim/mcore/../common -I../../include -I../../../binutils-gdb/sim/mcore/../../include -I../../bfd -I../../../binutils-gdb/sim/mcore/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/mcore/../../opcodes  -g -O2 -c -o interp.o -MT interp.o -MMD -MP -MF .deps/interp.Tpo ../../../binutils-gdb/sim/mcore/interp.c
>> ../../../binutils-gdb/sim/mcore/interp.c: In function ‘handle_trap1’:
>> ../../../binutils-gdb/sim/mcore/interp.c:559:22: warning: implicit declaration of function ‘link’ [-Wimplicit-function-declaration]
>>          cpu.gr[RET1] = link ((char *) a[0], (char *) a[1]);
>>                         ^
>>   ../../../binutils-gdb/sim/mcore/interp.c:585:22: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration]
>>          cpu.gr[RET1] = access ((char *) a[0], a[1]);
>>                         ^
>>
>> 2015-02-07  Chen Gang <gang.chen.5i5j@gmail.com>
>>
>>         * mcore/interp.c: Include "unistd.h" standard C header file to
>>         avoid compiling warnings.
> 
> LGTM

Excuse me, I am not quite familiar with the short word, I guess it is "
Look Good To ME",

Is what I guess correct?


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed


  reply	other threads:[~2015-02-07 23:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07 14:12 Chen Gang S
2015-02-07 23:22 ` Doug Evans
2015-02-07 23:54   ` Chen Gang S [this message]
2015-02-08  0:35     ` Doug Evans
2015-02-08  1:32       ` Chen Gang S
2015-02-08 16:00         ` Joel Brobecker
2015-02-09  1:48           ` Chen Gang S
2015-02-09  2:28             ` Joel Brobecker
2015-02-09 10:48               ` Chen Gang S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D6A794.7080107@sunrus.com.cn \
    --to=gang.chen@sunrus.com.cn \
    --cc=gdb-patches@sourceware.org \
    --cc=xdje42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox